Enhancing Publisher.OutstandingBatch by sduskis · Pull Request #5007 · googleapis/google-cloud-java · GitHub
Skip to content

Enhancing Publisher.OutstandingBatch#5007

Merged
sduskis merged 2 commits into
googleapis:masterfrom
sduskis:refactor_pubsub_0424
Apr 25, 2019
Merged

Enhancing Publisher.OutstandingBatch#5007
sduskis merged 2 commits into
googleapis:masterfrom
sduskis:refactor_pubsub_0424

Conversation

@sduskis

@sduskis sduskis commented Apr 24, 2019

Copy link
Copy Markdown
Contributor
  • Moving responsibility for creating the SettableFuture into OutstandingBatch
  • Moving responsibility for tracking message size into OutstandingBatch

- Moving responsibility for creating the SettableFuture into OutstandingBatch
- Moving responsibility for tracking message size into OutstandingBatch
@sduskis sduskis requested a review from a team April 24, 2019 17:58
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2019
@sduskis sduskis added api: pubsub Issues related to the Pub/Sub API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 24, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 24, 2019
@codecov

codecov Bot commented Apr 25, 2019

Copy link
Copy Markdown

@sduskis sduskis merged commit 909b0e8 into googleapis:master Apr 25, 2019
@sduskis sduskis deleted the refactor_pubsub_0424 branch April 25, 2019 15:04
@JesseLovelace JesseLovelace mentioned this pull request May 1, 2019
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
- Moving responsibility for creating the SettableFuture into OutstandingBatch
- Moving responsibility for tracking message size into OutstandingBatch
meltsufin pushed a commit that referenced this pull request May 1, 2026
- Moving responsibility for creating the SettableFuture into OutstandingBatch
- Moving responsibility for tracking message size into OutstandingBatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants