Include user project in seemsLikeADirectoryAndUsePseudoDirectories by JesseLovelace · Pull Request #4996 · googleapis/google-cloud-java · GitHub
Skip to content

Include user project in seemsLikeADirectoryAndUsePseudoDirectories#4996

Merged
JesseLovelace merged 6 commits into
masterfrom
includeuserproj
Apr 25, 2019
Merged

Include user project in seemsLikeADirectoryAndUsePseudoDirectories#4996
JesseLovelace merged 6 commits into
masterfrom
includeuserproj

Conversation

@JesseLovelace

Copy link
Copy Markdown
Contributor

Fixes #4960

seemsLikeADirectoryAndUsePseudoDirectories wasn't including the user project during a list call, which breaks for requester pays buckets.

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2019

@chingor13 chingor13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding an integration test for this?

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2019
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 24, 2019
@codecov

codecov Bot commented Apr 24, 2019

Copy link
Copy Markdown

@JesseLovelace JesseLovelace merged commit 902874f into master Apr 25, 2019
@sduskis sduskis deleted the includeuserproj branch May 1, 2019 17:39
@JesseLovelace JesseLovelace mentioned this pull request May 1, 2019
suztomo pushed a commit that referenced this pull request Mar 30, 2026
…4996)

* Include user project in seemsLikeADirectoryAndUsePseudoDirectories

* Include user project in seemsLikeADirectoryAndUsePseudoDirectories
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
…4996)

* Include user project in seemsLikeADirectoryAndUsePseudoDirectories

* Include user project in seemsLikeADirectoryAndUsePseudoDirectories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google-cloud-nio: calling Files.exists(path) on a non-existing object in a requester pays bucket throws an exception

6 participants