Cleaning up generics in SequentialExecutorService by sduskis · Pull Request #4982 · googleapis/google-cloud-java · GitHub
Skip to content

Cleaning up generics in SequentialExecutorService #4982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sduskis merged 1 commit into from
Apr 18, 2019
Merged

Cleaning up generics in SequentialExecutorService #4982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
View file
Open in desktop
6 changes: 3 additions & 3 deletions ...ogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/SequentialExecutorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ interface CancellableRunnable extends Runnable {
* key will be run only when its predecessor has been completed while tasks with different keys can
* be run in parallel.
*/
final class SequentialExecutorService<T> {
final class SequentialExecutorService {
private static final Logger logger = Logger.getLogger(SequentialExecutorService.class.getName());

private final CallbackExecutor callbackExecutor;
Expand All @@ -56,7 +56,7 @@ final class SequentialExecutorService<T> {
* Runs asynchronous {@code Callable} tasks sequentially. If one of the tasks fails, other tasks
* with the same key that have not been executed will be cancelled.
*/
ApiFuture<T> submit(final String key, final Callable<ApiFuture> callable) {
<T> ApiFuture<T> submit(final String key, final Callable<ApiFuture<T>> callable) {
return callbackExecutor.submit(key, callable);
}

Expand Down Expand Up @@ -146,7 +146,7 @@ private static class CallbackExecutor extends SequentialExecutor {
super(executor);
}

<T> ApiFuture<T> submit(final String key, final Callable<ApiFuture> callable) {
<T> ApiFuture<T> submit(final String key, final Callable<ApiFuture<T>> callable) {
final SettableApiFuture<T> future = SettableApiFuture.create();
execute(
key,
Expand Down
16 changes: 8 additions & 8 deletions ...-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/SequentialExecutorServiceTest.java
View file
Open in desktop