Remove bigtableadmin artifact by igorbernstein2 · Pull Request #4533 · googleapis/google-cloud-java · GitHub
Skip to content

Remove bigtableadmin artifact#4533

Merged
igorbernstein2 merged 4 commits into
googleapis:masterfrom
igorbernstein2:remove-bigtable
Feb 22, 2019
Merged

Remove bigtableadmin artifact#4533
igorbernstein2 merged 4 commits into
googleapis:masterfrom
igorbernstein2:remove-bigtable

Conversation

@igorbernstein2

@igorbernstein2 igorbernstein2 commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

Removes the google-bigtable-admin artifact (it was merged into the main bigtable artifact). Kokoro configs have been updated to stop referencing this artifact.

@igorbernstein2 igorbernstein2 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: bigtable Issues related to the Bigtable API. labels Feb 21, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2019
@igorbernstein2 igorbernstein2 changed the title WIP: Remove bigtableadmin artifact Remove bigtableadmin artifact Feb 21, 2019
@codecov

codecov Bot commented Feb 21, 2019

Copy link
Copy Markdown

@igorbernstein2 igorbernstein2 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 21, 2019
@igorbernstein2 igorbernstein2 marked this pull request as ready for review February 21, 2019 19:51
@igorbernstein2 igorbernstein2 requested a review from a team February 21, 2019 19:51
@kolea2

kolea2 commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

Just to confirm as it's a little hard to see in the diffs, does this PR remove the entire bigtable-admin module?

Comment thread versions.txt Outdated
@igorbernstein2

Copy link
Copy Markdown
Contributor Author

Yep, the entire module is removed, you can see how the tree looks here:
https://github.com/igorbernstein2/google-cloud-java/tree/remove-bigtable/google-cloud-clients

@sduskis

sduskis commented Feb 22, 2019

Copy link
Copy Markdown
Contributor

@igorbernstein2, can you please resolve the conflicts?

# Conflicts:
#	google-cloud-bom/pom.xml
#	google-cloud-clients/google-cloud-bigtable-admin/pom.xml
#	google-cloud-testing/google-cloud-bigtable-emulator/README.md
#	versions.txt
@igorbernstein2

Copy link
Copy Markdown
Contributor Author

@igorbernstein2 igorbernstein2 merged commit ed3a0c8 into googleapis:master Feb 22, 2019
@igorbernstein2 igorbernstein2 deleted the remove-bigtable branch February 22, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants