BigQuery: Fix timestamp parsing regression by pmakani · Pull Request #4510 · googleapis/google-cloud-java · GitHub
Skip to content

BigQuery: Fix timestamp parsing regression#4510

Merged
sduskis merged 2 commits into
googleapis:masterfrom
pmakani:api-bigquery-bug-4500
Feb 20, 2019
Merged

BigQuery: Fix timestamp parsing regression#4510
sduskis merged 2 commits into
googleapis:masterfrom
pmakani:api-bigquery-bug-4500

Conversation

@pmakani

@pmakani pmakani commented Feb 15, 2019

Copy link
Copy Markdown

Fixes #4500

@pmakani pmakani requested review from a team and sduskis February 15, 2019 21:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2019
@ajaaym ajaaym changed the title Fixes BigQuery timestamp parsing. BigQuery: Fix timestamp parsing regression Feb 15, 2019
@codecov

codecov Bot commented Feb 15, 2019

Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace timestampFormatter with your configuration for timestampValidator?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't be done with single formatter.

@pmakani pmakani force-pushed the api-bigquery-bug-4500 branch from 7700632 to 2387727 Compare February 19, 2019 17:23
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@sduskis sduskis added the api: bigquery Issues related to the BigQuery API. label Feb 20, 2019
@sduskis sduskis merged commit 7a6aa23 into googleapis:master Feb 20, 2019
@pmakani pmakani deleted the api-bigquery-bug-4500 branch February 25, 2019 12:36
@pmakani pmakani restored the api-bigquery-bug-4500 branch February 28, 2019 17:11
@pmakani pmakani deleted the api-bigquery-bug-4500 branch March 1, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants