Allowing non-POJO Firestore classes to be subclassed for mocking by schmidt-sebastian · Pull Request #3176 · googleapis/google-cloud-java · GitHub
Skip to content

Allowing non-POJO Firestore classes to be subclassed for mocking #3176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pongad merged 1 commit into from
Apr 26, 2018
Merged

Allowing non-POJO Firestore classes to be subclassed for mocking #3176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions google-cloud-firestore/src/main/java/com/google/cloud/firestore/CollectionReference.java
View file
Open in desktop
6 changes: 5 additions & 1 deletion google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,12 @@
* write, read, or listen to the location. There may or may not exist a document at the referenced
* location. A DocumentReference can also be used to create a CollectionReference to a
* subcollection.
*
* <p><b>Subclassing Note</b>: Firestore classes are not meant to be subclassed except for use in
* test mocks. Subclassing is not supported in production code and new SDK releases may break code
* that does so.
*/
public final class DocumentReference {
public class DocumentReference {

private final ResourcePath path;
private final FirestoreImpl firestore;
Expand Down
4 changes: 4 additions & 0 deletions google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentSnapshot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@
* <p>If the DocumentSnapshot points to a non-existing document, getData() and its corresponding
* methods will return null. You can always explicitly check for a document's existence by calling
* {@link #exists()}.
*
* <p><b>Subclassing Note</b>: Firestore classes are not meant to be subclassed except for use in
* test mocks. Subclassing is not supported in production code and new SDK releases may break code
* that does so.
*/
public class DocumentSnapshot {

Expand Down
6 changes: 5 additions & 1 deletion google-cloud-firestore/src/main/java/com/google/cloud/firestore/QueryDocumentSnapshot.java
View file
Open in desktop