iframe-proxy

pongad · 2018-01-11T02:41:38Z

vam-google

LGTM, but please strongly consider addressing the second comment.

Sign in to view

    private String query;
    private List<UserDefinedFunction> userDefinedFunctions;
-    private Boolean useLegacySql;
+    private Boolean useLegacySql = false;


Sign in to view

          UserDefinedFunction.TO_PB_FUNCTION));
    }
-    viewDefinition.setUseLegacySql(useLegacySql);
+    if (useLegacySql == null) {


pongad · 2018-01-12T01:57:00Z

Makes sense. Only default to false it is.

This reverts commit 955c952.

tswast

LGTM for views, though I'd expect a similar change to QueryJobConfiguration, also.

https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/QueryJobConfiguration.java#L107

I think it'd be confusing to change the behavior of views but not queries.

pongad · 2018-01-16T23:18:13Z

* deps: update github/codeql-action action to v2.20.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Min Zhu <zhumin@google.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [lxml](https://lxml.de/) ([source](https://togithub.com/lxml/lxml), [changelog](https://git.launchpad.net/lxml/plain/CHANGES.txt)) | `==5.2.1` -> `==5.2.2` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/lxml/5.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/lxml/5.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/lxml/5.2.1/5.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/lxml/5.2.1/5.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>lxml/lxml (lxml)</summary> ### [`v5.2.2`](https://togithub.com/lxml/lxml/blob/HEAD/CHANGES.txt#522-2024--) [Compare Source](https://togithub.com/lxml/lxml/compare/lxml-5.2.1...lxml-5.2.2) \================== ## Bugs fixed - [GH#417](https://togithub.com/GH/lxml/issues/417): The `test_feed_parser` test could fail if `lxml_html_clean` was not installed. It is now skipped in that case. - [LP#2059910](https://togithub.com/LP/lxml/issues/2059910): The minimum CPU architecture for the Linux x86 binary wheels was set back to "core2", without SSE 4.2. - If libxml2 uses iconv, the compile time version is available as `etree.ICONV_COMPILED_VERSION`. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/sdk-platform-java).

🤖 I have created a release *beep* *boop* --- <details><summary>2.40.1</summary> ## [2.40.1](googleapis/sdk-platform-java@v2.40.0...v2.40.1) (2024-05-15) ### Bug Fixes * [common-protos] An existing method `UpdateVehicleLocation` is ([a8848b4](googleapis/sdk-platform-java@a8848b4)) * [common-protos] An existing method `UpdateVehicleLocation` is removed from service `VehicleService` ([#2751](googleapis/sdk-platform-java#2751)) ([a8848b4](googleapis/sdk-platform-java@a8848b4)) * [iam] An existing method `UpdateVehicleLocation` is removed from ([04ab176](googleapis/sdk-platform-java@04ab176)) * [iam] An existing method `UpdateVehicleLocation` is removed from service `VehicleService` ([#2752](googleapis/sdk-platform-java#2752)) ([04ab176](googleapis/sdk-platform-java@04ab176)) * do not populate repo level change while removing library ([#2740](googleapis/sdk-platform-java#2740)) ([8d92d16](googleapis/sdk-platform-java@8d92d16)) * only append `.api.grpc` suffix to group id if the artifact id starts with `proto-` or `grpc-` ([#2731](googleapis/sdk-platform-java#2731)) ([b791c84](googleapis/sdk-platform-java@b791c84)) * opentelemetry-bom to be in third-party-dependencies BOM ([#2736](googleapis/sdk-platform-java#2736)) ([0700180](googleapis/sdk-platform-java@0700180)) * prepare to generate grafeas ([#2761](googleapis/sdk-platform-java#2761)) ([bf26ca1](googleapis/sdk-platform-java@bf26ca1)) * Replace deprecated protobuf methods. ([#2764](googleapis/sdk-platform-java#2764)) ([c1e586d](googleapis/sdk-platform-java@c1e586d)) ### Dependencies * update dependency black to v24.4.2 ([#2660](googleapis/sdk-platform-java#2660)) ([027191f](googleapis/sdk-platform-java@027191f)) * update dependency com.fasterxml.jackson:jackson-bom to v2.17.1 ([#2732](googleapis/sdk-platform-java#2732)) ([3e94c74](googleapis/sdk-platform-java@3e94c74)) * update dependency com.google.cloud:grpc-gcp to v1.6.0 ([#2767](googleapis/sdk-platform-java#2767)) ([e360a3d](googleapis/sdk-platform-java@e360a3d)) * update dependency com.google.errorprone:error_prone_annotations to v2.27.1 ([#2708](googleapis/sdk-platform-java#2708)) ([5ceb5fa](googleapis/sdk-platform-java@5ceb5fa)) * update dependency com.google.errorprone:error_prone_annotations to v2.27.1 ([#2709](googleapis/sdk-platform-java#2709)) ([94df49f](googleapis/sdk-platform-java@94df49f)) * update dependency com.google.oauth-client:google-oauth-client-bom to v1.36.0 ([#2768](googleapis/sdk-platform-java#2768)) ([f8500df](googleapis/sdk-platform-java@f8500df)) * update dependency commons-codec:commons-codec to v1.17.0 ([#2710](googleapis/sdk-platform-java#2710)) ([d1c14e9](googleapis/sdk-platform-java@d1c14e9)) * update dependency jinja2 to v3.1.4 [security] ([#2742](googleapis/sdk-platform-java#2742)) ([e0ebded](googleapis/sdk-platform-java@e0ebded)) * update dependency lxml to v5.2.2 ([#2766](googleapis/sdk-platform-java#2766)) ([99e23f7](googleapis/sdk-platform-java@99e23f7)) * update dependency markupsafe to v2.1.5 ([#2657](googleapis/sdk-platform-java#2657)) ([834b258](googleapis/sdk-platform-java@834b258)) * update dependency net.bytebuddy:byte-buddy to v1.14.15 ([#2753](googleapis/sdk-platform-java#2753)) ([7494d67](googleapis/sdk-platform-java@7494d67)) * update dependency platformdirs to v4.2.1 ([#2662](googleapis/sdk-platform-java#2662)) ([9118e55](googleapis/sdk-platform-java@9118e55)) * update googleapis/java-cloud-bom digest to db4265f ([#2755](googleapis/sdk-platform-java#2755)) ([afbbb78](googleapis/sdk-platform-java@afbbb78)) * update googleapis/java-cloud-bom digest to f3c611a ([#2700](googleapis/sdk-platform-java#2700)) ([de5a108](googleapis/sdk-platform-java@de5a108)) * update opentelemetry-java monorepo to v1.38.0 ([#2769](googleapis/sdk-platform-java#2769)) ([74a2451](googleapis/sdk-platform-java@74a2451)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com>

* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests. * For details on issue see - googleapis/java-spanner#2206 * Fixing lint issues. * feat: add support for Directed Read options. * chore: fix lint issues. * test: add unit tests for options class. * test: add tests using mock spanner. * test: add unit test for partitioned read. * test: add unit test for partitioned read. * chore: adding option in spanner options. * chore: fix NPE. * chore: disabling test on emulator. * chore: adding test for query in RW transaction. * chore: adding IT for transaction manager interface. * chore: disable IT for emulator. * chore: PR comments. * chore: address PR comments.

Remove beta annotations from artifact versions and class/methods on the public api.

…sion cloud-shared-deps (googleapis#2766) Change-Id: I48b4e84ffa45e3c380769274b374eeeac4d2bccb Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Rollback plan is reviewed and LGTMed - [ ] All new data plane features have a completed end to end testing plan Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).

bigquery: use standard SQL by default

955c952

Fixes #2748.

pongad requested review from garrettjonesgoogle, tswast and vam-google January 11, 2018 02:41

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2018

vam-google approved these changes Jan 11, 2018

View reviewed changes

pongad added 2 commits January 12, 2018 12:57

Revert "bigquery: use standard SQL by default"

7ec1b99

This reverts commit 955c952.

pr comment

bb7ec28

tswast reviewed Jan 16, 2018

View reviewed changes

tswast approved these changes Jan 17, 2018

View reviewed changes

pongad merged commit 8cac8b8 into googleapis:master Jan 17, 2018

pongad deleted the bq-standard branch January 17, 2018 06:05

chingor13 pushed a commit that referenced this pull request Mar 30, 2026

feat: promote gRPC transport to GA (#2766)

20397f5

Remove beta annotations from artifact versions and class/methods on the public api.

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bigquery: use standard SQL by default#2766

bigquery: use standard SQL by default#2766
pongad merged 3 commits into
googleapis:masterfrom
pongad:bq-standard

pongad commented Jan 11, 2018

Uh oh!

vam-google left a comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

pongad commented Jan 12, 2018

Uh oh!

tswast left a comment

Uh oh!

pongad commented Jan 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

pongad commented Jan 11, 2018

Uh oh!

vam-google left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

pongad commented Jan 12, 2018

Uh oh!

tswast left a comment

Choose a reason for hiding this comment

Uh oh!

pongad commented Jan 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants