{{ message }}
fixed shaded package name#1743
Closed
lbergelson wants to merge 1 commit into
Closed
Conversation
Fixed the maven shade command so it produces a valid shaded package name. It was producing shaded.cloud-nio.* which is not a valid java package and causes compilation errors when trying to import those packages. This is problematic since the shaded packages are exposed in the API, so methods that exposed them were unusable by client code. Shading now produces shading.cloud_nio.* which is valid
googlebot
added
the
cla: no
Contributor
Author
|
@jean-philippe-martin Could you take a look at this? |
|
Changes Unknown when pulling 6173700 on lbergelson:master into ** on GoogleCloudPlatform:master**. |
|
Looks good to me. |
Contributor
|
@lbergelson , could you do the CLA dance? |
Contributor
Author
|
@garrettjonesgoogle Sorry, I've been trying to talk to legal at the Broad. They've haven't responded to me yet. We have some sort of code sharing agreement already with google, but I'm not sure if they want me to sign the CLA or if there's some other agreement in place that takes precedent. |
Contributor
|
@jean-philippe-martin this change is pretty trivial - you could just make a different change that accomplishes the same thing and avoid the whole CLA issue. |
Contributor
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
chingor13
pushed a commit
that referenced
this pull request
Feb 24, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 12, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
suztomo
added a commit
that referenced
this pull request
Mar 30, 2026
lqiu96
pushed a commit
that referenced
this pull request
Apr 1, 2026
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
…1743) Bumps [org.xerial.snappy:snappy-java](https://github.com/xerial/snappy-java) from 1.1.10.3 to 1.1.10.4. - [Release notes](https://github.com/xerial/snappy-java/releases) - [Commits](xerial/snappy-java@v1.1.10.3...v1.1.10.4) --- updated-dependencies: - dependency-name: org.xerial.snappy:snappy-java dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
…1743) Bumps [org.xerial.snappy:snappy-java](https://github.com/xerial/snappy-java) from 1.1.10.3 to 1.1.10.4. - [Release notes](https://github.com/xerial/snappy-java/releases) - [Commits](xerial/snappy-java@v1.1.10.3...v1.1.10.4) --- updated-dependencies: - dependency-name: org.xerial.snappy:snappy-java dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the maven shade command so it produces a valid shaded package name. It was producing shaded.cloud-nio.* which is not a valid java package and causes compilation errors when trying to import those packages. This is problematic since the shaded packages are exposed in the API, so methods that exposed them were unusable by client code.
Shading now produces shading.cloud_nio.* which is valid