{{ message }}
do not expose Service#1553
Merged
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
Author
Contributor
|
It's hard to figure out what has changed and what has moved - can you point me to the points in the PR that need to actually be considered? |
Contributor
Author
|
@garrettjonesgoogle Essentially, all fields (non static ones) and all methods are moved into the inner |
pongad
commented
Jan 24, 2017
| logger.debug("Starting subscriber group."); | ||
| startStreamingConnections(); | ||
| notifyStarted(); | ||
| public enum State { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| TERMINATED | ||
| } | ||
|
|
||
| public abstract static class SubscriberListener { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
github-actions Bot
pushed a commit
to yoshi-code-bot/google-cloud-java
that referenced
this pull request
Nov 8, 2022
…s#1687) (googleapis#1553) * chore(java): add a note in README for migrated split repos Disable renovate bot and flaky bot for split repositories that have moved to the Java monorepo. The Java monorepo will pass the "monorepo=True" parameter to java.common_templates method in its owlbot.py files so that the migration note will not appear in the README in the monorepo. Co-authored-by: Jeff Ching <chingor@google.com> Source-Link: https://togithub.com/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
….37.0 (#1553) * fix(deps): Update the Java code generator (gapic-generator-java) to 2.37.0 PiperOrigin-RevId: 611816371 Source-Link: googleapis/googleapis@2a40f63 Source-Link: https://github.com/googleapis/googleapis-gen/commit/d30ff0767777b381fb1617f67a90e3abd3bdc6dc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDMwZmYwNzY3Nzc3YjM4MWZiMTYxN2Y2N2E5MGUzYWJkM2JkYzZkYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
🤖 I have created a release *beep* *boop* --- ## [3.16.1](https://togithub.com/googleapis/java-logging/compare/v3.16.0...v3.16.1) (2024-03-07) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.37.0 ([#1553](https://togithub.com/googleapis/java-logging/issues/1553)) ([15b05fc](https://togithub.com/googleapis/java-logging/commit/15b05fc4a8e6c4069414110b749525082821e509)) ### Dependencies * Update dependency com.google.cloud:sdk-platform-java-config to v3.27.0 ([#1552](https://togithub.com/googleapis/java-logging/issues/1552)) ([6c5464d](https://togithub.com/googleapis/java-logging/commit/6c5464d1c5a74962fcd459a1e03282747e148a44)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
….37.0 (googleapis#1553) * fix(deps): Update the Java code generator (gapic-generator-java) to 2.37.0 PiperOrigin-RevId: 611816371 Source-Link: googleapis/googleapis@2a40f63 Source-Link: https://github.com/googleapis/googleapis-gen/commit/d30ff0767777b381fb1617f67a90e3abd3bdc6dc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDMwZmYwNzY3Nzc3YjM4MWZiMTYxN2Y2N2E5MGUzYWJkM2JkYzZkYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
🤖 I have created a release *beep* *boop* --- ## [3.16.1](https://togithub.com/googleapis/java-logging/compare/v3.16.0...v3.16.1) (2024-03-07) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.37.0 ([googleapis#1553](https://togithub.com/googleapis/java-logging/issues/1553)) ([12bd21f](https://togithub.com/googleapis/java-logging/commit/12bd21ffab34e85a4e4af9f1f65b9afb570a7a14)) ### Dependencies * Update dependency com.google.cloud:sdk-platform-java-config to v3.27.0 ([googleapis#1552](https://togithub.com/googleapis/java-logging/issues/1552)) ([0b94696](https://togithub.com/googleapis/java-logging/commit/0b946963f15565ef4438afafa6481656adfeab7d)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Mar 30, 2026
lqiu96
pushed a commit
that referenced
this pull request
Apr 1, 2026
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
…o v1.123.9 (#1553) * chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.123.9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
…o v1.123.9 (#1553) * chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.123.9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure how ready this PR is. The general logic is to hide the implementation in a subclass then create a delegator. If the approach looks fine to you, I'll go ahead and document the methods.