{{ message }}
fix(spanner): preserve call options when applying statement timeout#13017
Open
akash329d wants to merge 2 commits into
Open
fix(spanner): preserve call options when applying statement timeout#13017akash329d wants to merge 2 commits into
akash329d wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies AbstractBaseUnitOfWork.java to ensure that existing GrpcCallContext options, such as affinity keys, are preserved when configuring call timeouts. By building from the provided input context instead of creating a default one, the change prevents existing call options from being dropped during the merge process. There were no review comments provided for this pull request, so I have no feedback to provide regarding the review itself.
rahul2393
approved these changes
May 21, 2026
Contributor
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12726. The grpc-gcp affinity routing it (and googleapis/grpc-gcp-java#235) introduced is bypassed when a
statement_timeoutis set. With multiplexed sessions every data RPC then falls back to the api-configaffinity_key: "session"rule and has the same original issue.Build the configurator's result from the input
contextinstead so the call options survive the merge. The relative timeout is still applied;merge()already requires aGrpcCallContext, so the cast is safe.