{{ message }}
chore: update hermetic build docker volume usage#10770
Closed
diegomarquezp wants to merge 14 commits into
Closed
Conversation
Contributor
Author
Contributor
Author
|
From https://github.com/googleapis/google-cloud-java/actions/runs/8913106957/job/24477945575?pr=10770 This is because |
diegomarquezp
added
the
do not merge
JoeWang1127
reviewed
May 1, 2024
| --target-library-names=<library_name if specified; otherwise api_shortname> | ||
| docker run --rm -u $(id -u):$(id -g) -v $(pwd):/workspace --entrypoint \ | ||
| python gcr.io/cloud-devrel-public-resources/java-library-generation:latest \ | ||
| /src/generate_repo.py generate \ |
Contributor
There was a problem hiding this comment.
Could you change this command to use entry_point.py because the cli in generate_repo.py will be removed soon.
blakeli0
reviewed
May 1, 2024
| -v /var/run/docker.sock:/var/run/docker.sock \ | ||
| -e "RUNNING_IN_DOCKER=true" \ | ||
| -e "REPO_BINDING_VOLUMES=-v ${repo_volumes}" \ | ||
| -u "$(id -u):$(id -g)" \ |
Contributor
There was a problem hiding this comment.
I guess this is the command enables us to modify/delete the docker generated files?
Contributor
Author
There was a problem hiding this comment.
yes, including ownership takeover performed by the container
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of googleapis/sdk-platform-java#2615
The way we use the docker image changed with that pull request. Here we adapt to those changes.