iframe-proxy

jean-philippe-martin · 2016-06-21T18:25:23Z

I used grep -R -L 'LICENSE-2' * | grep '\.java' | grep -v 'generated-sources' to find those files; I changed them all (including some outside of NIO).

Sign in to view

@@ -1,3 +1,18 @@
+/*


jart · 2016-06-21T19:19:49Z

Unrelated side note: Why doesn't this project follow go/releasing/authors and go/releasing/contributions?

aozarov · 2016-06-21T19:27:28Z

Unrelated side note: Why doesn't this project follow go/releasing/authors and go/releasing/contributions?

We probably should at some point, but considering what is says in go/releasing/contributions I don't think it matters that much at this point. Also, a discussion about it should probably be in gcloud-common.

jean-philippe-martin · 2016-06-21T19:54:05Z

@aozarov

I've added checks. They work from the IDE, but not from the command line. It looks like they have a different idea of what CWD is:

gcloud-java$ mvn -amd -pl gcloud-java-contrib compile
GCloud Java NIO .................................... FAILURE [  1.203 s]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on project gcloud-java-nio: Failed during checkstyle configuration: cannot initialize module Header - Unable to find: src/main/checkstyle/java.header -> [Help 1]

gcloud-java$ file gcloud-java-contrib/gcloud-java-nio/src/main/checkstyle/java.header
gcloud-java-contrib/gcloud-java-nio/src/main/checkstyle/java.header: ASCII text

If I change the path to gcloud-java-contrib/gcloud-java-nio/src/main/checkstyle/java.header then it works from the command line, but not from the IntelliJ IDE:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on project gcloud-java-nio: Failed during checkstyle configuration: cannot initialize module Header - Unable to find: gcloud-java-contrib/gcloud-java-nio/src/main/checkstyle/java.header -> [Help 1]

Help welcome.

mziccard · 2016-06-21T20:32:21Z

Out of curiosity: in Intellij do you run the build by selecting gcloud-java or gcloud-java-contrib?

jean-philippe-martin · 2016-06-21T20:34:27Z

In intellij I validate gcloud-java-nio by going to the "Maven Projects" tab, right-clicking gcloud-java-nio>validate, and selecting "Run Maven build".

Sign in to view

+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */


mziccard · 2016-06-21T20:39:28Z

In intellij I validate gcloud-java-nio by going to the "Maven Projects" tab, right-clicking gcloud-java-nio>validate, and selecting "Run Maven build".

This is probably the reason for the error, Intellij runs maven in the gcloud-java-nio directory thus not finding gcloud-java-contrib/gcloud-java-nio/src/main/checkstyle/java.header.

BTW, feel free to remove this check and open an issue for it, I will take care of adding it for the whole project.

jean-philippe-martin · 2016-06-21T20:46:07Z

With pleasure. I removed it and created issue #1071.

Sign in to view

@@ -1,5 +1,5 @@
 /*
- * Copyright 2015 Google Inc. All Rights Reserved.
+ * Copyright 2016 Google Inc. All Rights Reserved.


…#1067)

🤖 I have created a release *beep* *boop* --- ## [2.3.4](googleapis/java-translate@v2.3.3...v2.3.4) (2022-09-15) ### Dependencies * Update dependency com.google.cloud:google-cloud-core to v2.8.10 ([#1069](googleapis/java-translate#1069)) ([2bee3ba](googleapis/java-translate@2bee3ba)) * Update dependency com.google.cloud:google-cloud-core to v2.8.11 ([#1073](googleapis/java-translate#1073)) ([8a869f6](googleapis/java-translate@8a869f6)) * Update dependency com.google.cloud:google-cloud-core to v2.8.9 ([#1066](googleapis/java-translate#1066)) ([69d391c](googleapis/java-translate@69d391c)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1074](googleapis/java-translate#1074)) ([c8bfd65](googleapis/java-translate@c8bfd65)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1077](googleapis/java-translate#1077)) ([aa9ef02](googleapis/java-translate@aa9ef02)) * Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#1060](googleapis/java-translate#1060)) ([4d9a7ad](googleapis/java-translate@4d9a7ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* cleanup: remove migrated sample * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * cleanup: remove dangling tests Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…s to v2.12.0 (#1067)

…cies to v3.0.3 (#1067) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `3.0.2` -> `3.0.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.3/compatibility-slim/3.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.3/confidence-slim/3.0.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-logging).

🤖 I have created a release *beep* *boop* --- ## [3.11.1](googleapis/java-logging@v3.11.0...v3.11.1) (2022-09-15) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1067](googleapis/java-logging#1067)) ([6d36ffc](googleapis/java-logging@6d36ffc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* creating sum aggregation * creating avg aggregation * refactoring code to configure alias into an aggregation * Add method in aggregation query builders to accept aggregation in var args form * refactoring equals implementation * changed visibility from public to protected * Made aggregation result capable of returning double values * clirr ignore new method * Made transformer capable of parsing double values * mock webserver simulating sum and avg aggregation response * integration tests for sum and avg * Marking sum and avg methods with @BetaApi annotation * incorporating feedbacks * fixing lint * refactoring dispatcher code * incorporating feedbacks * cleaing up proxy code, as sum/avg now can be run against nightly * remove deprecated annotation * tests for sum and avg aggregations in GQL query * removing the addaggregation variant accepting list of aggregations * fix lint failures * removed BetaApi annotation from sum and avg aggregation * adding doc to AggregationResult#getDouble * adding sum/avg aggreggation test with autogenerated alias * adding a test to run sum and avg aggregation together * testing sum and avg aggregations with transactions * type check before returning the result from aggregation result class

…cies to v3.0.3 (googleapis#1067) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `3.0.2` -> `3.0.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.3/compatibility-slim/3.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.3/confidence-slim/3.0.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-logging).

🤖 I have created a release *beep* *boop* --- ## [3.11.1](googleapis/java-logging@v3.11.0...v3.11.1) (2022-09-15) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([googleapis#1067](googleapis/java-logging#1067)) ([aeb4086](googleapis/java-logging@aeb4086)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [0.126.0](https://togithub.com/googleapis/java-storage-nio/compare/v0.125.0...v0.126.0) (2022-12-09) ### Features * FileSystemProvider::readAttributes faked posix support ([#1067](https://togithub.com/googleapis/java-storage-nio/issues/1067)) ([9982cba](https://togithub.com/googleapis/java-storage-nio/commit/9982cba637db5f6263fe0c2d638948f2fdd8c279)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

jean-philippe-martin added 2 commits June 21, 2016 11:18

Add Apache license

50cea2d

Add Apache license to non-NIO files too

c4a6186

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2016

aozarov reviewed Jun 21, 2016
View reviewed changes

Automate license check

e4cb222

now compiles from command line, but not from IDE anymore

d425cbc

mziccard reviewed Jun 21, 2016
View reviewed changes

jean-philippe-martin mentioned this pull request Jun 21, 2016

Add compile-time check that source files start with license text #1071

Closed

jean-philippe-martin added 2 commits June 21, 2016 13:46

cosmetic, and remove checkstyle header checking

6729f7b

We are in 2016

b623b3d

mziccard reviewed Jun 22, 2016
View reviewed changes

mziccard merged commit 867278a into googleapis:gcs-nio Jun 23, 2016

jean-philippe-martin deleted the stamp_license_everywhere branch June 23, 2016 17:21

mziccard pushed a commit to mziccard/gcloud-java that referenced this pull request Jun 29, 2016

Make sure every java file starts with the Apache license. (googleapis…

16de3c2

…#1067)

mziccard pushed a commit to mziccard/gcloud-java that referenced this pull request Jun 30, 2016

Make sure every java file starts with the Apache license. (googleapis…

5917ae7

…#1067)

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update dependency com.google.api.grpc:proto-google-common-proto…

e00de03

…s to v2.12.0 (#1067)

chingor13 pushed a commit that referenced this pull request Jan 6, 2026

chore(main): release 0.129.12-SNAPSHOT (#1067)

3e79bd2

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

suztomo pushed a commit that referenced this pull request Mar 30, 2026

feat: FileSystemProvider::readAttributes faked posix support (#1067)

9982cba

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

feat: FileSystemProvider::readAttributes faked posix support (#1067)

4666a10

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

jean-philippe-martin commented Jun 21, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

jart commented Jun 21, 2016

Uh oh!

aozarov commented Jun 21, 2016

Uh oh!

jean-philippe-martin commented Jun 21, 2016

Uh oh!

mziccard commented Jun 21, 2016

Uh oh!

jean-philippe-martin commented Jun 21, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

mziccard commented Jun 21, 2016

Uh oh!

jean-philippe-martin commented Jun 21, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants