{{ message }}
fix(bigtable): DynamicChannelPoolSizingPolicyOption used correctly#16188
Merged
scotthart merged 4 commits intoJun 24, 2026
Conversation
product-auto-label
Bot
added
the
api: bigtable
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for configuring the DynamicChannelPoolSizingPolicyOption when creating a BigtableStub with the random two least used decorator. It introduces accessor methods to retrieve the channel pool and its sizing policy, along with a unit test to verify the policy propagation. The review feedback recommends returning the shared pointer by const& in pool() and using auto const& in the test to avoid unnecessary copies and atomic reference count overhead.
dbolduc
approved these changes
Jun 24, 2026
dbolduc
reviewed
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.