{{ message }}
This repository was archived by the owner on Mar 26, 2026. It is now read-only.
fix: minor typo in ads template#664
Merged
Merged
Conversation
google-cla
Bot
added
the
cla: yes
software-dov
requested review from
arithmetic1728,
busunkim96,
crwilcox and
lukesneeringer
busunkim96
approved these changes
Oct 15, 2020
busunkim96
left a comment
busunkim96
left a comment
Contributor
There was a problem hiding this comment.
Is this code not being exercised in the unit tests?
Contributor
Author
|
It looks like it isn't. The |
arithmetic1728
approved these changes
Oct 15, 2020
Contributor
Author
CircleCI machinery now invokes the alternative (Ads) templates for the showcase_alternative_templates_* tests. Includes numerous fixes and additions to the Ads grpc transport, client class, and unit test templates. The showcase system tests now selectively enable async tests via an environment variable. The async client code has not yet been added to the Ads templates, and the corresponding system tests have been disabled for alternative templates.
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #631