fix: fix typo attribue -> attribute by busunkim96 · Pull Request #627 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: fix typo attribue -> attribute#627

Merged
software-dov merged 1 commit into
masterfrom
busunkim96-patch-5
Sep 30, 2020
Merged

fix: fix typo attribue -> attribute#627
software-dov merged 1 commit into
masterfrom
busunkim96-patch-5

Conversation

@busunkim96

Copy link
Copy Markdown
Contributor

Closes #626

It might be nice to add fake grpc service configs to make sure this bit of the template is tested.

@busunkim96 busunkim96 requested review from a team and software-dov September 30, 2020 19:10
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2020

@software-dov software-dov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! Fatfinger on my part.

@codecov

codecov Bot commented Sep 30, 2020

Copy link
Copy Markdown

@software-dov software-dov merged commit 729146f into master Sep 30, 2020
@software-dov software-dov deleted the busunkim96-patch-5 branch September 30, 2020 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.34.0 fails to generate grafeas v1

3 participants