{{ message }}
This repository was archived by the owner on Mar 26, 2026. It is now read-only.
feat: add iam methods to templates#545
Merged
Merged
Conversation
google-cla
Bot
added
the
cla: yes
software-dov
approved these changes
Jul 22, 2020
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #536
This adds a new generator option
add-iam-methods.The option adds the three standard IAM methods
get_iam_policy,set_iam_policy, andtest_iam_permissions. This option is a replacement forreroute_to_grpc_interfacein the monolith.reroute_to_grpc_interfaceis used by KMS and Pub/Sub to expose the IAM methods. Future clients are not expected to use this option.This PR copy-pastes the IAM methods from the cloud functions client into the templates. The only edits are to the endpoint.
I tried
get_iam_policywith KMS and I get the same result as the existing library.The down-side of copy-pasting is that this code is prone to being missed in changes to the templated methods/tests. I tried adding the methods at the API schema level but was unsuccessful. I'm not very familiar with how the schema works, so if there's a good way to make the change at that level I'm happy to rework this PR.
Failing showcase tests should pass once proto-plus
1.3.2makes it to PyPI.