fix: fix wrong unit test by arithmetic1728 · Pull Request #502 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: fix wrong unit test#502

Merged
software-dov merged 1 commit into
masterfrom
sijun/fix
Jul 8, 2020
Merged

fix: fix wrong unit test#502
software-dov merged 1 commit into
masterfrom
sijun/fix

Conversation

@arithmetic1728

@arithmetic1728 arithmetic1728 commented Jul 8, 2020

Copy link
Copy Markdown
Contributor

Endpoints are wrong in some tests.

Endpoint shouldn't be hard coded unless it is explicitly provided in client_options, otherwise it should be client.DEFAULT_ENDPOINT or client.DEFAULT_MTLS_ENDPOINT.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 8, 2020
@codecov

codecov Bot commented Jul 8, 2020

Copy link
Copy Markdown

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants