iframe-proxy

daniel-sanche · 2026-03-13T21:29:45Z

Currently, our constraints files are above the minimum-supported version. We need to be testing minimum versions, which means either bumping up the minimum, or lowering the constraint

For this fix:

added new constraints-3.9-async-rest.txt file, so the async_rest extra can have its own minimum versions
changes the minimum api_core version to 2.17.1, to incorporate this fix. Lower versions encountered a fragment test that seemed to be a real bug with Rest clients
while touching these constraints, I also added a grpcio constraint, to resolve #2453. We bumped the version to 1.44.0, to match google-cloud-iam

gemini-code-assist · 2026-03-13T21:29:59Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request initiates testing against the minimum supported versions of project dependencies. It specifically adjusts the pinned versions of google-api-core and google-auth within the constraints-3.9.txt.j2 file. The primary goal is to identify and address compatibility issues that arise when running tests with these lower dependency versions, ultimately ensuring the project functions correctly across its defined support matrix.

Highlights

Dependency Version Lowering: Lowered the pinned versions of google-api-core and google-auth in constraints-3.9.txt.j2 to test against minimum supported versions.
Addressing Issue use google-auth2.14.1 in tests #2568: This change is part of an effort to resolve an issue where current constraints files exceed minimum supported versions, aiming to either fix tests or update requirements.

Changelog

gapic/templates/testing/constraints-3.9.txt.j2
- Updated google-api-core from 2.21.0 to 2.11.0.
- Updated google-auth from 2.35.0 to 2.14.1.

Activity

The pull request was opened by daniel-sanche as a DRAFT.
The author is testing the impact of lowering dependency constraints to minimum supported versions.
The PR aims to identify issues that arise from these changes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request lowers the pinned versions for google-api-core and google-auth in the constraints file for Python 3.9, as part of an effort to test against minimum supported dependency versions. This is a good exploratory change. However, I noticed that the constraints files for Python 3.10, 3.11, and 3.12 currently use _default_constraints.j2, which results in testing against the latest compatible dependency versions rather than the minimums. To ensure consistent and comprehensive testing of the minimum requirements across all supported Python versions, I recommend extending this change to also pin the lower bounds in the constraints files for Python 3.10-3.12.

chore: fix testing pins to target minimum supported versions

0d6dca0

product-auto-label Bot added the size: xs Pull request size is extra small. label Mar 13, 2026

gemini-code-assist Bot reviewed Mar 13, 2026

View reviewed changes

daniel-sanche added 2 commits March 13, 2026 15:05

upgrade api-core version

dbbf80b

attempt constraint modification

3d121a2

product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 13, 2026

fixed constraints parsing

22f24bf

daniel-sanche commented Mar 13, 2026

View reviewed changes

Comment thread noxfile.py Outdated

updated goldens

75d703f

product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 14, 2026

daniel-sanche and others added 10 commits March 17, 2026 11:08

Merge branch 'main' into update_min_versions

628d730

use dict for new constraints

e892758

downgraded api-core

d01d897

improved replacement logic

c43c636

fixed variable name

863b4aa

fixed syntax

a9f35e7

use generated async-rest constraints files

fb5c1c3

remove hard-code to 3.9 in rest constraint

6665b36

bump api_core requirements

096bc27

add grpc constraint

31a2913

daniel-sanche changed the title ~~[DRAFT] chore: testing constraints target minimum supported versions~~ chore: testing constraints target minimum supported versions Mar 18, 2026

daniel-sanche marked this pull request as ready for review March 18, 2026 00:03

daniel-sanche requested a review from a team as a code owner March 18, 2026 00:03

blunderbuss-gcf Bot assigned tswast Mar 18, 2026

daniel-sanche added 2 commits March 17, 2026 17:22

updated grpcio constraint

00a573a

use higher grpcio for fragment tests

aa96b40

daniel-sanche commented Mar 18, 2026

View reviewed changes

Comment thread gapic/templates/testing/constraints-3.9.txt.j2 Outdated

daniel-sanche assigned vchudnov-g and unassigned tswast Mar 20, 2026

daniel-sanche and others added 2 commits March 23, 2026 14:51

set grpc floor to 1.44.0

d9e0b6f

Merge branch 'main' into update_min_versions

02ce1a0

gkevinzheng approved these changes Mar 24, 2026

View reviewed changes

gkevinzheng merged commit d2216aa into main Mar 25, 2026
113 checks passed

gkevinzheng deleted the update_min_versions branch March 25, 2026 14:27

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: testing constraints target minimum supported versions#2590

chore: testing constraints target minimum supported versions#2590
gkevinzheng merged 19 commits into
mainfrom
update_min_versions

daniel-sanche commented Mar 13, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Mar 13, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

daniel-sanche commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Mar 13, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daniel-sanche commented Mar 13, 2026 •

edited

Loading