{{ message }}
This repository was archived by the owner on Mar 26, 2026. It is now read-only.
tests: update repo location for core deps#2566
Merged
Merged
Conversation
Contributor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request correctly updates the repository locations for google-api-core and proto-plus in the noxfile configurations by modifying the gapic/templates/noxfile.py.j2 template. However, several noxfile.py files within the tests/integration/goldens directories, which appear to be generated, have also been directly modified. According to the repository's general rules, fixes for generated code should be applied solely to the generator templates to ensure consistency across the codebase. These generated files should be updated by regenerating them after the template modification, rather than through direct edits.
ohmayr
approved these changes
Feb 19, 2026
This was referenced Feb 19, 2026
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Feb 20, 2026
This PR is needed to update the `core_deps_from_source` nox session to point to the new location for `google-api-core` in the monorepo https://github.com/googleapis/google-cloud-python/tree/main/packages/google-api-core https://github.com/googleapis/google-cloud-python/blob/edd2b7ae39899124747ff62769287f4458387e0c/packages/google-apps-meet/noxfile.py#L600 See googleapis/gapic-generator-python#2566
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/googleapis/python-api-core has moved to https://github.com/googleapis/google-cloud-python/tree/main/packages/google-api-core
https://github.com/googleapis/proto-plus-python has moved to https://github.com/googleapis/google-cloud-python/tree/main/packages/proto-plus