chore: stop testing on node 6 in ci by kjin · Pull Request #1024 · googleapis/cloud-trace-nodejs · GitHub
Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

chore: stop testing on node 6 in ci#1024

Merged
soldair merged 1 commit into
googleapis:masterfrom
kjin:node-6-ded
May 9, 2019
Merged

chore: stop testing on node 6 in ci#1024
soldair merged 1 commit into
googleapis:masterfrom
kjin:node-6-ded

Conversation

@kjin

@kjin kjin commented May 9, 2019

Copy link
Copy Markdown
Contributor

We've already "dropped" support for Node 6 in #1011, this allows us to start acting on that.

@kjin kjin requested a review from a team May 9, 2019 18:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 9, 2019
@codecov

codecov Bot commented May 9, 2019

Copy link
Copy Markdown

@bcoe bcoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thank you @kjin

@soldair soldair merged commit 1e5c9be into googleapis:master May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants