{{ message }}
feat(cli): add 'Esc to close' hint to AuthDialog#25809
Open
JayadityaGit wants to merge 2 commits intogoogle-gemini:mainfrom
Open
feat(cli): add 'Esc to close' hint to AuthDialog#25809JayadityaGit wants to merge 2 commits intogoogle-gemini:mainfrom
JayadityaGit wants to merge 2 commits intogoogle-gemini:mainfrom
Conversation
Contributor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the AuthDialog component in the CLI UI to include instructions for closing the dialog using the Escape key. Specifically, the helper text was updated from "(Use Enter to select)" to "(Use Enter to select, Esc to close)", and the corresponding test snapshots were updated to reflect this change. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an "Esc to close" hint to the
AuthDialogUI to inform users that they can dismiss the authentication dialog by pressing the Escape key.Details
AuthDialogfrom(Use Enter to select)to(Use Enter to select, Esc to close).packages/cli/src/ui/auth/__snapshots__/AuthDialog.test.tsx.snapto match the new UI text.Related Issues
Fixes #25726
How to Validate
npm run startto launch the CLI.(Use Enter to select, Esc to close).Escand verify the dialog behavior (it should attempt to close or show a message if closure is restricted by state).Pre-Merge Checklist