{{ message }}
This repository was archived by the owner on Apr 18, 2026. It is now read-only.
Improve String.prototype.startsWith polyfill#554
Closed
mathiasbynens wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Strange indentation on these lines.
Also, is the check for search really needed? The common case is that search is provided and if it is falsey it will fail on the toString check anyway.
if (this == null || $toString.call(search) == '[object RegExp]') {
throw TypeError();
}
Member
Author
There was a problem hiding this comment.
I wanted to avoid the toString.call whenever possible for performance reasons, but yeah, in the common case it won’t make a difference. I’ll make the change.
Contributor
There was a problem hiding this comment.
You could probably skip it in the common case by doing one of.
- typeof
- Compare the searchString to search
Contributor
|
Thanks for taking care of these. I was secretly hoping you would take care of these (and StringIterator, hint hint) |
Member
Author
|
You’re welcome! Amended the commit as per your remarks. |
Contributor
mathiasbynens
added a commit
to mathiasbynens/String.prototype.startsWith
that referenced
this pull request
Dec 17, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch replaces the old
String.prototype.startsWithpolyfill with http://mths.be/startswith, while also adding the tests from that project.