{{ message }}
This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Fix load pem private key with the PEM encoded data#162
Open
g1im2 wants to merge 1 commit into
Open
Conversation
greateggsgreg
suggested changes
Sep 19, 2019
greateggsgreg
left a comment
greateggsgreg
left a comment
Contributor
There was a problem hiding this comment.
This definitely needs to be fixed. An alternative method is to open the files in binary (mode "rb") so we don't need to convert to bytes after the fact. Example:
with open(rsa_key_path + '.pub', 'rb') as rsa_pub_file:
self.public_key = rsa_pub_file.read()
with open(rsa_key_path, 'rb') as rsa_prv_file:
self.rsa_key = serialization.load_pem_private_key(
rsa_prv_file.read(), None, default_backend())
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix problem like this issues "pyca/cryptography#2730", and it also happened in here.