Consider switching to `WiX 5.0.2` from `WiX 4.0.5` · Issue #1070 · google/mozc · GitHub
Skip to content

Consider switching to WiX 5.0.2 from WiX 4.0.5 #1070

Closed

Description

@yukawa

Description

WiX 5.0.2 was released on Oct 4, 2024.

Unlike WiX 5.0.1, which failed to compile our installer_oss_64bit.wxs, WiX 5.0.2 looks to have no issue on building it without any modification.

Steps to reproduce

Steps to reproduce the behavior:

  1. Replace 4.0.5 with 5.0.2 in the following files.
  • mozc/dotnet-tools.json

    Lines 1 to 12 in ace3145

  • mozc/src/MODULE.bazel

    Lines 165 to 168 in ace3145

    dotnet_tool_repository(
    name = "wix",
    version = "4.0.5",
    )
  • mozc/src/WORKSPACE.bazel

    Lines 225 to 230 in ace3145

  1. Build Mozc (with either GYP or Bazel)

Expected behavior

There is no difference in Mozc64.msi built.

Actual behavior

There is no difference in Mozc64.msi built.

Version or commit-id

ace3145

Environment

  • OS: Windows 11 23H2

Activity

  1. changed the title [-]Consider switching to `Wix 5.0.2` from `WiX 4.0.5`[/-] [+]Consider switching to `WiX 5.0.2` from `WiX 4.0.5`[/+] on Oct 6, 2024
  2. yukawa commented on Oct 6, 2024

    @yukawa
    CollaboratorAuthor

    @hiroyuki-komatsu Can you take a look at this when you have time? I guess all we need to do is just replacing 4.0.5 with 5.0.2 in the above 3 files.

  3. hiroyuki-komatsu commented on Oct 6, 2024

    @hiroyuki-komatsu
    Collaborator

    Sure!

  4. hiroyuki-komatsu commented on Oct 7, 2024

    @hiroyuki-komatsu
    Collaborator

    Done.

  5. added a commit that references this issue on Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions