{{ message }}
Repository navigation
Conversation
Generate export data during Nogo's existing source analysis and read it with the supported x/tools API. Replace deprecated compiler-archive decoding, reusing the type-checked package when serializing exports. Declare standard-library exports per SDK and build mode. Protobuf rules previously supplied no source files to Nogo and used compiler exports for downstream types. Pass their generated sources and compiler-declared runtime dependencies through the existing analysis action to produce source exports. Diagnostics and facts now run for these packages through the same path. Exempt only the unsafe-import filename diagnostic for generated .pb.go files, since protoc-gen-go emits unsafe descriptor access. On one amd64 worker, serial warm-cache Nogo analysis of sync and eventchannel and their dependencies took 83.5-85.4 s before and 84.8-85.0 s after (two measured passes per revision). This includes standard-library work, export writes and newly analyzed protobuf dependencies; compilation and downloads are excluded. Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate export data during Nogo's existing source analysis and read it
with the supported x/tools API. Replace deprecated compiler-archive
decoding, reusing the type-checked package when serializing exports.
Declare standard-library exports per SDK and build mode.
Protobuf rules previously supplied no source files to Nogo and used
compiler exports for downstream types. Pass their generated sources and
compiler-declared runtime dependencies through the existing analysis
action to produce source exports. Diagnostics and facts now run for
these packages through the same path.
Exempt only the unsafe-import filename diagnostic for generated .pb.go
files, since protoc-gen-go emits unsafe descriptor access.
On one amd64 worker, serial warm-cache Nogo analysis of sync and
eventchannel and their dependencies took 83.5-85.4 s before and
84.8-85.0 s after (two measured passes per revision). This includes
standard-library work, export writes and newly analyzed protobuf
dependencies; compilation and downloads are excluded.
Assisted-by: Codex