{{ message }}
Repository navigation
Conversation
tamird
force-pushed
the
fix/ipv6-quoted-extension-headers
branch
from
October 22, 2026 00:19
4913272 to
7a48d5a
Compare
nybidari
approved these changes
Oct 22, 2026
Collaborator
ICMPv6 errors may quote a packet whose transport header follows IPv6 extension headers. Walk the existing payload iterator to find that header, and share its protocol and offset between control delivery, conntrack lookup, and NAT rewriting. Accept truncated payloads while rejecting incomplete extension headers and non-initial fragments. Widen the iterator's length arithmetic before converting extension length units to bytes. Preserve the existing IPv4 options policy and minimum TCP/UDP header requirements. Cover quoted UDP/TCP NAT errors, first and atomic fragments, malformed quotes, long extension headers, and mutation across buffer views.
tamird
force-pushed
the
fix/ipv6-quoted-extension-headers
branch
from
October 25, 2026 12:25
7a48d5a to
af38f71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICMPv6 errors that quoted packets with extension headers could lose
transport error delivery or miss the NAT connection. Control delivery
handled only an immediate fragment header, while conntrack and NAT
assumed the transport header started after the fixed IPv6 header.
Use the existing IPv6 payload iterator to find the transport protocol
and offset, and share that result between control delivery, connection
lookup, and NAT rewriting. Preserve truncated quotes with enough header
bytes, reject incomplete extensions and non-initial fragments, and widen
the iterator's extension-length arithmetic before multiplication.
Regressions cover quoted UDP/TCP NAT errors, direct control delivery,
first and atomic fragments, malformed quotes, long extension headers,
and mutation across buffer views. The affected suites and owning
analyzer and format checks passed on Linux.