{{ message }}
Installation: Use *Timestamp instead of *time.Time for the benefit of InstallationEvent#965
Merged
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
Author
gmlewis
approved these changes
Aug 5, 2018
gmlewis
left a comment
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @bmoylan!
You definitely found a bug, so we have no problems breaking the API when the current implementation doesn't work. We will need to label this repo with a new version for the breaking change.
LGTM.
Awaiting second LGTM before merging.
juliaferraioli
approved these changes
Aug 6, 2018
juliaferraioli
left a comment
juliaferraioli
left a comment
Contributor
There was a problem hiding this comment.
Very nice catch, @bmoylan!
LGTM.
Collaborator
gmlewis
pushed a commit
to gmlewis/go-github
that referenced
this pull request
Aug 10, 2018
PatWie
added a commit
to PatWie/pylint
that referenced
this pull request
Aug 14, 2018
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://developer.github.com/v3/activity/events/types/#installationevent the
created_atandupdated_attimestamps in the event payloads are unix-formatted, while the CRUD APIs use RFC3339. Using*Timestamphandles the unfortunate fact that the API is inconsistent. Without this change, my application emits the following errorI understand this might be a breaking change to the public API, so I'm open to feedback if there are alternative ways to proceed.
This change is