Update orgs_members.go by mlbright · Pull Request #871 · google/go-github · GitHub
Skip to content

Update orgs_members.go#871

Merged
gmlewis merged 2 commits into
google:masterfrom
mlbright:patch-1
Aug 10, 2018
Merged

Update orgs_members.go#871
gmlewis merged 2 commits into
google:masterfrom
mlbright:patch-1

Conversation

@mlbright

Copy link
Copy Markdown
Contributor

role filter 'member' means return only users that are not owners

role filter 'member' means return only users that are not owners
@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Mar 16, 2018
Comment thread github/orgs_members.go Outdated

@dmitshur dmitshur Mar 30, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation of role values at https://developer.github.com/v3/orgs/members/#members-list says:

  • member - Non-owner organization members.

Would using that phrasing be better?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@googlebot

Copy link
Copy Markdown

@googlebot googlebot added cla: no and removed cla: yes Indication that the PR author has signed a Google Contributor License Agreement. labels Aug 10, 2018
@gmlewis gmlewis merged commit 747f93d into google:master Aug 10, 2018
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Aug 10, 2018
@mlbright mlbright deleted the patch-1 branch August 12, 2018 04:21
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants