{{ message }}
remove ListOptions from RepositoryListAllOptions (they have no effect)#751
Merged
Conversation
googlebot
added
the
cla: yes
dmitshur
approved these changes
Oct 13, 2017
dmitshur
left a comment
dmitshur
left a comment
Member
There was a problem hiding this comment.
Confirmed. Even the per_page option has no effect.
LGTM. Thanks!
We'll need to bump libraryVersion up by one, since this is a breaking API change:
Line 30 in 0f6d3ce
Feel free to do that, otherwise we can do it before merging ourselves.
Member
|
I'll bump |
googlebot
added
cla: no
and removed
cla: yes
nbareil
pushed a commit
to nbareil/go-github
that referenced
this pull request
May 1, 2018
The standard pagination options have no effect in the /repositories endpoint, both empirically and according to the documentation: > Note: Pagination is powered exclusively by the since parameter. Use the > Link header to get the URL for the next page of repositories. GitHub API docs: https://developer.github.com/v3/repos/#list-all-public-repositories Bump up libraryVersion since this is a breaking API change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard pagination options have no effect in the
/repositoriesendpoint, both empirically and according to the documentation: https://developer.github.com/v3/repos/#list-all-public-repositories