fix import statement by themousepotato · Pull Request #1020 · google/go-github · GitHub
Skip to content

fix import statement#1020

Merged
gmlewis merged 1 commit into
google:masterfrom
themousepotato:potato-patch
Oct 27, 2018
Merged

fix import statement#1020
gmlewis merged 1 commit into
google:masterfrom
themousepotato:potato-patch

Conversation

@themousepotato

Copy link
Copy Markdown
Contributor

Correct import statement and update according to https://godoc.org/github.com/google/go-github/github.

@googlebot

Copy link
Copy Markdown

@themousepotato

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Sep 30, 2018
@gmlewis

gmlewis commented Oct 1, 2018

Copy link
Copy Markdown
Collaborator

I don't think this is correct. Please see discussion in #985.

@themousepotato

Copy link
Copy Markdown
Contributor Author

Hey @gmlewis !

I tested the code. It wasn't working. I updated it as https://godoc.org/github.com/google/go-github/github. If this isn't correct, it should be corrected. From my testing experience, I can say that this is correct. Please test it once in the meantime.

@gmlewis

gmlewis commented Oct 2, 2018

Copy link
Copy Markdown
Collaborator

Thanks, @themousepotato.

What version of Go are you using?

Is your environment variable GO111MODULE set?
If so, what is its value?

Have you read the docs on Go modules and specifically release information here:
https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher
?

One thing we are trying to do is move toward supporting Go v1.11 and beyond by adding support for Go modules.

@themousepotato

Copy link
Copy Markdown
Contributor Author

@gmlewis Sorry for the late reply. Here you go:
go version go1.11 linux/amd64

GO111MODULE env var is not set. I only tried to keep in sync with the docs on https://godoc.org/github.com/google/go-github/github. Thanks!

@gmlewis

gmlewis commented Oct 5, 2018

Copy link
Copy Markdown
Collaborator

Thanks, @themousepotato, for the extra info.
@marwan-at-work - do you have time to take a look at this PR and comment please?

@marwan-at-work marwan-at-work left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, thank you!

Comment thread README.md Outdated
@themousepotato

Copy link
Copy Markdown
Contributor Author

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Merging.

@gmlewis gmlewis merged commit 60c18f2 into google:master Oct 27, 2018
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants