Use master instead of tip for .travis.yml by gmlewis · Pull Request #1002 · google/go-github · GitHub
Skip to content

Use master instead of tip for .travis.yml#1002

Merged
gmlewis merged 3 commits into
google:masterfrom
gmlewis:tip-vs-master-experiment
Sep 11, 2018
Merged

Use master instead of tip for .travis.yml#1002
gmlewis merged 3 commits into
google:masterfrom
gmlewis:tip-vs-master-experiment

Conversation

@gmlewis

@gmlewis gmlewis commented Sep 11, 2018

Copy link
Copy Markdown
Collaborator

This is an experiment to address this question:
#985 (comment)

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Sep 11, 2018
@gmlewis gmlewis force-pushed the tip-vs-master-experiment branch from d86c760 to 2a8e4e3 Compare September 11, 2018 00:23
@gmlewis gmlewis requested a review from dmitshur September 11, 2018 00:36
@gmlewis

gmlewis commented Sep 11, 2018

Copy link
Copy Markdown
Collaborator Author

@gmlewis gmlewis mentioned this pull request Sep 11, 2018

@dmitshur dmitshur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I don't see the check on this PR

I see it:

image

Also in PR list view:

image

LGTM. This is what the Travis documentation recommends, and it's what this repo and many others have used for many months. tip was used by Travis a few years ago (and they still maintain it for backwards compatibility).

@gmlewis

gmlewis commented Sep 11, 2018

Copy link
Copy Markdown
Collaborator Author

@gmlewis gmlewis merged commit 13f1685 into google:master Sep 11, 2018
@gmlewis gmlewis deleted the tip-vs-master-experiment branch September 11, 2018 11:47
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants