{{ message }}
Repository navigation
Pin three.js example to r127 - #1252
Merged
igorvytyaz merged 2 commits intoOct 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the webgl_loader_draco.html example by switching the three.js CDN from rawgit to jsdelivr and setting a relative decoder path for the DRACOLoader. The review feedback suggests converting the relative decoder path to an absolute URL using new URL to prevent potential path resolution issues inside the Web Worker.
This was referenced Oct 16, 2026
igorvytyaz
approved these changes
Oct 16, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The example in
javascript/example/webgl_loader_draco.htmlappears to be broken onmain, linking to the latest version of three.js from a CDN. Locally, the code is not compatible with three.js versions more recent than r127. r128 introduced ES6 class syntax, which requires updating the DRACOLoader implementation.I've tested the example with this change. It works against Draco v1.5.7 but not v1.5.8. I'm hoping this could be helpful to reproduce what I believe to be a regression in the v1.5.8 WASM module. In v1.5.8 I see the following errors in the console:
In Node.js, via glTF Transform, I see a different set of errors, described in #1251, though these might be related. As three.js will eventually try to access HEAPF32, I believe it will eventually hit the same error once the immediate wasm module loading error above is resolved.
Aside - It might be worth using the version of DRACOLoader distributed with three.js rather than a local copy. That'd be easier to keep updated, though perhaps less helpful for illustrative purposes?