{{ message }}
[small ops safety] Improve operator safety for generated .env files#5427
Open
failuresmith wants to merge 2 commits intogoogle:mainfrom
Open
[small ops safety] Improve operator safety for generated .env files#5427failuresmith wants to merge 2 commits intogoogle:mainfrom
failuresmith wants to merge 2 commits intogoogle:mainfrom
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
adk createalways writes a.envfile..gitignorewith.env..gitignoreentries are preserved, and.envis not duplicated.Why
If ADK creates
.envby default, it should also ignore that file by default. This avoids relying on operator accuracy for a predictable secret-handling risk.Testing
PYTHONPATH=src pytest tests/unittests/cli/utils/test_cli_create.pyPYTHONPATH=src pytest tests/unittests/cli/utils/test_cli_tools_click.py::test_cli_create_cmd_invokes_run_cmd tests/unittests/cli/test_cli_tools_click_option_mismatch.py::test_adk_createadk create l1generated.gitignorecontaining.envNotes
git diff --checkpassed.pyinkandisortwere not available in the current uv environment, so formatter checks could not be run locally.