{{ message }}
Repository navigation
fix(history): close stdin for git processes - #365
Merged
Merged
Conversation
No git command a run calls reads stdin, so the redirect and the close looked removable, and the suite, which runs without a terminal, stayed green without them. A stand-in git now names its stdin and reads it to the end; the comments in GitCli say why both lines are there (#348).
…moves it Keeps the guarantee for what Chartula itself writes in plain mode, no control characters and nothing beyond ASCII, which the help text still gives. Names the sequence, that it follows stdout and stdin rather than stderr, that CI and NO_COLOR leave it like --plain does, and that TERM=dumb removes it. One sentence per line (#348).
4 tasks
Owner
goldbarth
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #348
Verified:
dotnet format Chartula.slnx --verify-no-changes reports existing formatting and line-ending issues across the repository, including files untouched by this change.
Tests:
dotnet test Chartula.slnx -c Release(1,082 passed in the last recorded run, before the maintainer-added regression test; the current branch has not been rerun locally because .NET SDK 10.0.111 is unavailable).