iframe-proxy

cpunion · 2026-09-08T00:40:25Z

When a generic function's method expression is specialized, its
reconstructed selection signature has already adapted the receiver and
lost the method type parameters. Instantiating that signature with the
method's type arguments panics in go/types.

Instantiate the declared method's signature before adapting its receiver,
then restore the selected receiver. Remove the unused selection signature
and the code that constructed it. The separate signature canonicalization
fix in CL 835365 is now in master and is not duplicated here.

Add regression cases for an ordinary function with a matching signature,
a pointer receiver, and a promoted method. Test both SSA builder modes.
Track the larger receiver-handling cleanup in golang/go#81708.

Verified with go test ./go/ssa/... and, in the gopls module,
go test -short ./internal/test/marker on Go 1.27.2 darwin/arm64.

Fixes golang/go#81385

gopherbot · 2026-09-08T01:05:22Z

gopherbot · 2026-09-18T18:40:48Z

Message from Alex Putman:

Patch Set 1: Code-Review+1 Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-18T18:40:49Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-09-18T18:14:32Z","revision":"4c91ba82c258de55341a0e3cf0f318a7300b81df"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-18T18:40:50Z

Message from Alex Putman:

Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_4809514>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-18T18:40:50Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-arm64_debian13 has failed with summary (view all results):

go on master (commit 3544f81) / tools on master (change 828905)

To reproduce, try gomote repro 8670299285755254001.

Additional links for debugging:

test golang.org/x/tools/gopls module output

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-18T18:40:51Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-18T21:47:30Z

Message from Mark Freeman:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-23T17:02:42Z

Message from Alex Putman:

Patch Set 1: -Code-Review

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-23T18:05:10Z

This PR (HEAD: 339909a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/828905.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-09-23T18:45:32Z

Message from Jie Li:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-23T20:30:20Z

Message from Alex Putman:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-23T20:30:21Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-09-23T19:51:03Z","revision":"bebc2ebab875fd63a7c5125c1c04ab11e1f48ecc"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-23T20:50:58Z

Message from Alex Putman:

Patch Set 3: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_4809514>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-23T20:50:59Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-23T20:51:00Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-24T15:40:48Z

Message from Alex Putman:

Patch Set 3: Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-24T16:00:11Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-09-24T15:17:37Z","revision":"bebc2ebab875fd63a7c5125c1c04ab11e1f48ecc"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-24T16:20:27Z

Message from Alex Putman:

Patch Set 3: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_4809514>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-24T16:20:28Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-24T18:04:14Z

Message from Alex Putman:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-24T19:26:52Z

This PR (HEAD: 66311af) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/828905.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-09-24T20:08:38Z

Message from Jie Li:

Patch Set 4:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-09-25T18:26:26Z

Message from Alan Donovan:

Patch Set 4:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-09T08:03:33Z

This PR (HEAD: 0399027) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/828905.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-10-09T11:08:02Z

Message from Jie Li:

Patch Set 5:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-15T15:41:55Z

Message from Peter Weinberger:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

When a generic function method expression is specialized, its reconstructed selection signature has already adapted the receiver and lost the method type parameters. Instantiate the selected method object signature first, then restore the selected receiver. Keep instantiated method signatures out of the canonical type cache. Signature identity ignores receivers, so caching a method signature can cause an ordinary function instance to acquire a receiver and panic while building its instantiation wrapper. Split regression coverage for ordinary functions, pointer receivers, and promoted methods. Test both generic builder modes and document the planned receiver handling refactor. Fixes golang/go#81385

gopherbot · 2026-10-21T01:14:50Z

Message from Jie Li:

Patch Set 5:

(1 comment)

Pushed d17ab50 and rebased onto current master. go test ./go/ssa/... and go test -short ./internal/test/marker (in gopls) pass with Go 1.27.2. Could someone rerun TryBots?

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-21T01:14:58Z

This PR (HEAD: 8c86f84) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/828905.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-10-24T22:23:57Z

Message from Peter Weinberger:

Patch Set 6: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-24T22:38:22Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-10-24T22:09:20Z","revision":"833a750c337967837c09211d06441ab5ba734615"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-24T22:38:23Z

Message from Peter Weinberger:

Patch Set 6: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5260>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-24T22:38:23Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/828905.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-24T22:38:24Z

cpunion force-pushed the codex/ssa-generic-method-receiver-upstream-20260908 branch from 9473e31 to 339909a Compare September 23, 2026 18:02

cpunion force-pushed the codex/ssa-generic-method-receiver-upstream-20260908 branch from 339909a to 66311af Compare September 24, 2026 19:16

cpunion force-pushed the codex/ssa-generic-method-receiver-upstream-20260908 branch from 66311af to 0399027 Compare October 9, 2026 07:42

cpunion force-pushed the codex/ssa-generic-method-receiver-upstream-20260908 branch from 0399027 to d17ab50 Compare October 21, 2026 00:50

cpunion added 2 commits October 21, 2026 08:54

go/ssa: remove unused selection signature

8c86f84

cpunion force-pushed the codex/ssa-generic-method-receiver-upstream-20260908 branch from d17ab50 to 8c86f84 Compare October 21, 2026 00:56

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

cpunion commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Sep 8, 2026

Uh oh!

gopherbot commented Sep 18, 2026

Uh oh!

gopherbot commented Sep 18, 2026

Uh oh!

gopherbot commented Sep 18, 2026

Uh oh!

gopherbot commented Sep 18, 2026

Uh oh!

gopherbot commented Sep 18, 2026

Uh oh!

gopherbot commented Sep 18, 2026

Uh oh!

gopherbot commented Sep 23, 2026

Uh oh!

gopherbot commented Sep 23, 2026

Uh oh!

gopherbot commented Sep 23, 2026

Uh oh!

gopherbot commented Sep 23, 2026

Uh oh!

gopherbot commented Sep 23, 2026

Uh oh!

gopherbot commented Sep 23, 2026

Uh oh!

gopherbot commented Sep 23, 2026

Uh oh!

gopherbot commented Sep 23, 2026

Uh oh!

gopherbot commented Sep 24, 2026

Uh oh!

gopherbot commented Sep 24, 2026

Uh oh!

gopherbot commented Sep 24, 2026

Uh oh!

gopherbot commented Sep 24, 2026

Uh oh!

gopherbot commented Sep 24, 2026

Uh oh!

gopherbot commented Sep 24, 2026

Uh oh!

gopherbot commented Sep 24, 2026

Uh oh!

gopherbot commented Sep 25, 2026

Uh oh!

gopherbot commented Oct 9, 2026

Uh oh!

gopherbot commented Oct 9, 2026

Uh oh!

gopherbot commented Oct 15, 2026

Uh oh!

gopherbot commented Oct 21, 2026

Uh oh!

gopherbot commented Oct 21, 2026

Uh oh!

gopherbot commented Oct 24, 2026

Uh oh!

gopherbot commented Oct 24, 2026

Uh oh!

gopherbot commented Oct 24, 2026

Uh oh!

gopherbot commented Oct 24, 2026

Uh oh!

gopherbot commented Oct 24, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

cpunion commented Sep 8, 2026 •

edited

Loading