{{ message }}
Repository navigation
internal/export/idna: check the Bidi rule against mapped labels - #74
Open
DeviousCardi wants to merge 1 commit into
Open
DeviousCardi wants to merge 1 commit into
DeviousCardi wants to merge 1 commit into
Conversation
validateAndMap decided whether a name is a Bidi domain name from the Bidi class of each input rune, not of its UTS golang#46 mapping. U+2135 (L) maps to U+05D0 (R), so ToASCII("aℵb") skipped the Bidi rule and returned "xn--ab-vld", which ToASCII then rejects. Use the Bidi class of the mapping for mapped runes, as UTS golang#46, Section 4.1 requires. Fixes golang/go#81525
DeviousCardi
force-pushed
the
fix-81525-idna-bidi-after-mapping
branch
from
September 30, 2026 05:15
7176177 to
3f3ab26
Compare
Contributor
|
This PR (HEAD: 3f3ab26) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/text/+/841765. Important tips:
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

validateAndMap decided whether a name is a Bidi domain name from the
Bidi class of each input rune, not of its UTS #46 mapping. U+2135 (L)
maps to U+05D0 (R), so ToASCII("aℵb") skipped the Bidi rule and
returned "xn--ab-vld", which ToASCII then rejects. Use the Bidi class
of the mapping for mapped runes, as UTS #46, Section 4.1 requires.
Fixes golang/go#81525
Written by Codex.