internal/export/idna: check the Bidi rule against mapped labels by DeviousCardi · Pull Request #74 · golang/text · GitHub
Skip to content

internal/export/idna: check the Bidi rule against mapped labels - #74

Open
DeviousCardi wants to merge 1 commit into
golang:masterfrom
DeviousCardi:fix-81525-idna-bidi-after-mapping
Open

DeviousCardi wants to merge 1 commit into
golang:masterfrom
DeviousCardi:fix-81525-idna-bidi-after-mapping

Conversation

@DeviousCardi

@DeviousCardi DeviousCardi commented Sep 30, 2026 •

Copy link
Copy Markdown

validateAndMap decided whether a name is a Bidi domain name from the
Bidi class of each input rune, not of its UTS #46 mapping. U+2135 (L)
maps to U+05D0 (R), so ToASCII("aℵb") skipped the Bidi rule and
returned "xn--ab-vld", which ToASCII then rejects. Use the Bidi class
of the mapping for mapped runes, as UTS #46, Section 4.1 requires.

Fixes golang/go#81525

Written by Codex.

@google-cla

google-cla Bot commented Sep 30, 2026

Copy link
Copy Markdown

validateAndMap decided whether a name is a Bidi domain name from the
Bidi class of each input rune, not of its UTS golang#46 mapping. U+2135 (L)
maps to U+05D0 (R), so ToASCII("aℵb") skipped the Bidi rule and
returned "xn--ab-vld", which ToASCII then rejects. Use the Bidi class
of the mapping for mapped runes, as UTS golang#46, Section 4.1 requires.

Fixes golang/go#81525
@DeviousCardi
DeviousCardi force-pushed the fix-81525-idna-bidi-after-mapping branch from 7176177 to 3f3ab26 Compare September 30, 2026 05:15
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 3f3ab26) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/text/+/841765.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/net/idna: Bidi rule evaluated before UTS 46 mapping

2 participants