{{ message }}
Repository navigation
Conversation
The migration to outgoingrequests.* ran while setting defaults, before the config file and environment were read, so it only ever saw default values. webhooks.proxyurl, webhooks.proxypassword and webhooks.allownonroutableips have been ignored since they were deprecated.
Vikunja refuses to start when either is set. Ignoring a removed webhooks.proxyurl would silently send requests without the proxy. BREAKING CHANGE: webhooks.proxyurl and webhooks.allownonroutableips were removed. Use outgoingrequests.proxyurl and outgoingrequests.allownonroutableips instead.
github-actions
Bot
added
area/config
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecated
webhooks.proxyurl/webhooks.allownonroutableipsreplaced byoutgoingrequests.*. Drop them and their migration for next major.Hold until next major. Based on #4060 (moves the migration code deleted here); GitHub retargets to
mainwhen #4060 merges.webhooks.proxypasswordleft alone: #4059 removes it. Both PRs add removed keys to the sameremovedConfigKeystable, so the merge conflict = union of entries.Breaking changes
webhooks.proxyurlandwebhooks.allownonroutableipshave been removed. Vikunja now refuses to start when either one is set, from the config file or the environment, and the error names theoutgoingrequests.*key to use instead. Silently ignoring a removedwebhooks.proxyurlwould send outgoing requests without the configured proxy.How to verify
webhooks.proxyurl: http://mole:8080in the config (orVIKUNJA_WEBHOOKS_PROXYURL=http://mole:8080) and start Vikunja.config key "webhooks.proxyurl" was removed, use outgoingrequests.proxyurl instead.outgoingrequests.proxyurl: http://mole:8080and start Vikunja again.