{{ message }}
test: regenerate keyword fixtures from keywords.txt - #3473
Merged
Conversation
keywords.json had 41 keys added by hand that were missing from keywords.txt, so regenerating silently dropped them. Add them to keywords.txt, let keywords.py carry a per-keyword JSON value for the four entries whose value matters, and regenerate all three files. Closes #3120 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
A union member named ToString hides object.ToString and dotnet run prints warning CS0108 to stdout, which the fixture parses as JSON. Surfaced by the regenerated keyword-unions.schema. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3120
Why
test/keywords.json,keyword-enum.schema, andkeyword-unions.schemaare generated bytest/make-keyword-tests.shfromtest/keywords.txt. Over the last few weeks 41 keys were added tokeywords.jsonby hand without touchingkeywords.txt, so running the generator deleted them. Four of those entries also carry hand-written values (a date-time, an enum array,null, a UUID) that make generated code use a same-named runtime helper. The generator could not produce those.What
keywords.pyaccepts an optional tab-separated JSON literal after a keyword and uses it as the sample value. Default stays123.keywords.txtgains the 41 missing names in the file's existing order, with values for the four typed entries.keywords.jsonare unchanged; only the 64-per-chunkobjNboundaries moved. The two schemas gain the 41 names as enum values and union properties, which is new coverage for every language.Regenerating a second time is a no-op. Ran typescript, javascript, golang, rust, and swift JSON and schema fixtures on the changed inputs locally. Other languages depend on CI.
Supersedes #3121.
🤖 Generated with Claude Code