{{ message }}
Add menu options to open remote in Browser#67
Closed
mangerlahn wants to merge 3 commits into
Closed
Conversation
• Works for the hosts GitHub and Bitbucket • Added the default shortcut ⇧⌘O • More can be added easily • Also: Tweaked the loop which adds the target and ref to context menu items during creation
the method remoteUrls is only used internally by the class
Contributor
rjmunro
reviewed
Jan 28, 2021
| NSString* path = remoteURL.absoluteString; | ||
|
|
||
| if ([path containsString:@"github.com"]) { | ||
| [[NSWorkspace sharedWorkspace] openURL:remoteURL]; |
There was a problem hiding this comment.
Will this work for SSH URLs like git@github.com:gitx/gitx.git?
It would be good to have a method that takes a git URL and returns a website URL, then you could easily write unit tests for URLs of different forms.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Works for the hosts GitHub and Bitbucket
• Added the default shortcut ⇧⌘O
• More can be added easily
• Also: Tweaked the loop which adds the target and ref to context menu
items during creation