few small diff view improvements by toy · Pull Request #551 · gitx/gitx · GitHub
Skip to content

few small diff view improvements#551

Merged
hannesa2 merged 3 commits into
gitx:masterfrom
toy:sticky-file-name-in-diff
Jun 11, 2026
Merged

few small diff view improvements#551
hannesa2 merged 3 commits into
gitx:masterfrom
toy:sticky-file-name-in-diff

Conversation

@toy

@toy toy commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
  • the background below the diffs is made same as diffs background
  • make top link not so oddly positioned
  • make file name of each diff stick to the top of the page

please tell me if I should split into separate PRs

note was now
both background and top link positioning a-was-dark a-now-dark
only top link positioning a-was-light a-now-light
file name stickiness b-was-dark b-now-dark
ditto b-was-light b-now-light

@hannesa2

hannesa2 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Please can you provide a before-image and a after-image ?
Additional, please can you rebase to recent master, as I added a don't-run-screenshot-compare-on-fork. So I can see, if this will work properly

@toy toy force-pushed the sticky-file-name-in-diff branch from f18bd44 to 7de7097 Compare June 9, 2026 22:21
@toy

toy commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@hannesa2 I've added screenshots to the PR description and rebased yesterday

@hannesa2

Copy link
Copy Markdown
Contributor

@hannesa2 hannesa2 force-pushed the sticky-file-name-in-diff branch 2 times, most recently from 4e61fe2 to 7de7097 Compare June 11, 2026 04:16
@hannesa2 hannesa2 merged commit a7289ec into gitx:master Jun 11, 2026
4 of 6 checks passed
@toy toy deleted the sticky-file-name-in-diff branch June 11, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants