Test installing project on CI by EliahKagan · Pull Request #90 · gitpython-developers/gitdb · GitHub
Skip to content

Test installing project on CI#90

Merged
Byron merged 1 commit intogitpython-developers:masterfrom
EliahKagan:ci-install
Sep 11, 2023
Merged

Test installing project on CI#90
Byron merged 1 commit intogitpython-developers:masterfrom
EliahKagan:ci-install

Conversation

@EliahKagan
Copy link
Copy Markdown
Member

This changes the CI workflow to install the project itself to get its dependency, rather than installing the dependency from requirements.txt. This is the more important thing to test, because it verifies that the project is installable and effectively declares the dependencies it needs.

This changes the CI workflow to install the project itself to get
its dependency, rather than installing the dependency from
requirements.txt. This is the more important thing to test, because
it verifies that the project is installable and effectively
declares the dependencies it needs.
@EliahKagan EliahKagan marked this pull request as ready for review September 11, 2023 06:36
Copy link
Copy Markdown
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I was never aware the . syntax even existed and wonder if ultimately is just finds requirements.txt by convention, or if there is any other source of dependency information.

@Byron Byron merged commit d22ac20 into gitpython-developers:master Sep 11, 2023
@EliahKagan
Copy link
Copy Markdown
Member Author

@EliahKagan EliahKagan deleted the ci-install branch September 11, 2023 07:29
@Byron
Copy link
Copy Markdown
Member

Byron commented Sep 11, 2023

EliahKagan added a commit to EliahKagan/smmap that referenced this pull request Sep 17, 2023
This updates smmap's CI configuration in ways that are in line with
recent updates to gitdb's. In most cases there is no difference in
the changes, and the reason for the updates is more to avoid
confusing differences than from the value of the changes
themselves. In one case, there is a major difference (fetch-depth).

- gitpython-developers/gitdb#89 (same)

- gitpython-developers/gitdb#90 (same)
  It's just the project, not dependencies, but otherwise the same.

- gitpython-developers/gitdb#92 (opposite)
  This is the major difference. We don't need more than the tip of
  the branch in these tests. Keeping the default fetch-depth of 1
  by not setting it explicitly avoids giving the impression that
  the tests here are doing something they are not (and also serves
  as a speed optimization).

- gitpython-developers/gitdb#93 (same)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants