{{ message }}
Repository navigation
ci(sonar): wait for the quality gate before finishing the scan - #789
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





What
Set
sonar.qualitygate.wait=true(with a 300s timeout) insonar-project.propertiesso the SonarQube Cloud scan step fails the workflow when the project's quality gate is not OK.Why
Today the scan job reports success regardless of the quality gate result, so a failing gate never fails a check owned by our CI. This mirrors setchy/atlassify#3889, bringing the website in line with atlassify. The gate already scopes to New Code (Clean as You Code), so this only blocks newly introduced issues, not the existing backlog.
Notes
sonar.qualitygate.timeout=300is the scanner default and SonarCloud's practical maximum; it is set explicitly for clarity.sonar.sources=./src), so it contributes no New Code and should pass the gate itself..github/workflows/sonarcloud.ymlis unchanged; the scan action readssonar-project.properties.Verification
Planned via the OpenSpec change
enforce-sonar-quality-gate:Opened as a draft while the CI behaviour above is confirmed on this PR.