Fixes from a full run-through#4
Conversation
|
🔴 There was an error parsing your |
|
🔴 There was an error parsing your |
|
|
||
| 1. Since we cloned the repository earlier, let's run `git checkout master` to put us back on the master branch | ||
| 1. Run `git pull` to update your local repository with the changes we merged from the contributor's pull request | ||
| 1. Run `git filter-branch --index-filter "git rm -rf --cached --ignore-unmatch .env" HEAD` to remove the historical reference to the `.env` file |
There was a problem hiding this comment.
@a-a-ron this command didn't get rid of the commits from my history 😢
There was a problem hiding this comment.
@hectorsector this command doesn't remove the commit itself from the history but rather remove all content within the commit relating to the .env file
|
@a-a-ron I've gone through this course and everything seems to work. I'd love your 👀 because I changed a fair amount of things, and a run through of the updated gates if you have the time. The only exception to "everything works" is #4 (comment). |
| left: '848cd8c, 56d6fbb' | ||
| operator: test | ||
| left: '/(Add .env file)|(Remove .env file)/g' | ||
| operator: '!test' |
There was a problem hiding this comment.
Hey @hectorsector, the previous command removes the commit contents relating to the .env file, it doesn't remove the entire commits from history. I had this validation against the original commit IDs because those would change with the command but i'm open to a better way for validation.
However, with this validation and because the commits along with their commit messages remain, I don't get the last bot response from this step that sends me to the congratulations issue.
There was a problem hiding this comment.
OK I understand now, that's not clear from the responses so I'll make those adjustments and then merge.
|
Thanks @hectorsector for making these changes! Everything looks great other than the last gate validation against the commits. |
2 participants
This PR contains my fixes from a full run-through of the course.
Closes #3