Add install notes for GitHub Pages by a-a-ron · Pull Request #17 · githubtraining/github-pages · GitHub
Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Add install notes for GitHub Pages#17

Merged
hectorsector merged 3 commits into
masterfrom
ghes-install-notes
May 10, 2019
Merged

Add install notes for GitHub Pages#17
hectorsector merged 3 commits into
masterfrom
ghes-install-notes

Conversation

@a-a-ron

@a-a-ron a-a-ron commented May 8, 2019

Copy link
Copy Markdown
Contributor

@a-a-ron a-a-ron requested a review from hectorsector May 8, 2019 22:21
Comment thread server-installation-notes.md Outdated

@hectorsector hectorsector May 9, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should reorder the rows in this table so the required rows are first, especially the "GitHub Pages" dependency since the course is about GitHub Pages. For the alternative, we might suggest that this course can be used to teach Jekyll without pages, and then the existing instructions about changing responses and config.yml.

@hectorsector

Copy link
Copy Markdown
Contributor

@hectorsector hectorsector merged commit 2709ff4 into master May 10, 2019
@hectorsector hectorsector deleted the ghes-install-notes branch May 10, 2019 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants