Add Cooklang by dubadub · Pull Request #7497 · github-linguist/linguist · GitHub
Skip to content

Add Cooklang#7497

Merged
lildude merged 10 commits into
github-linguist:mainfrom
cooklang:main
Aug 26, 2025
Merged

Add Cooklang#7497
lildude merged 10 commits into
github-linguist:mainfrom
cooklang:main

Conversation

@dubadub

@dubadub dubadub commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Description

Adds support for Cooklang, markup language for recipes. https://cooklang.org

Checklist:

@dubadub dubadub requested a review from a team as a code owner July 21, 2025 15:18
@dubadub dubadub changed the title feat: add Cooklang Add Cooklang Jul 21, 2025

@lildude lildude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you haven't followed the instructions in CONTRIBUTING.md as had you done so you'd have found your grammar is not compatible as the script/add-grammar command would have failed to find a grammar in the repo.

Why? Because grammar is not TextMate compatible. Sublime 3 grammars are not TextMate compatible. We only support TextMate compatible grammars.

@dubadub

dubadub commented Jul 21, 2025

Copy link
Copy Markdown
Contributor Author

@dubadub dubadub requested a review from lildude July 21, 2025 16:41
Comment thread lib/linguist/languages.yml Outdated
@dubadub dubadub requested a review from lildude July 21, 2025 17:07
@dubadub dubadub marked this pull request as draft July 28, 2025 09:50
@dubadub dubadub marked this pull request as ready for review July 28, 2025 09:50
@dubadub

dubadub commented Jul 28, 2025

Copy link
Copy Markdown
Contributor Author

Hey @lildude , I'm a bit struggling with UI and wondering if you can help me with understanding are there any changes required from my side or it's all good now?

@dubadub

dubadub commented Jul 28, 2025

Copy link
Copy Markdown
Contributor Author

Some inaccessible submodules cause it to fail:

Error updating vendor/grammars/language-ring
Cloning into '/home/runner/work/linguist/linguist/vendor/grammars/language-ring'...
fatal: could not read Username for 'https://github.com/': No such device or address
fatal: clone of 'https://github.com/MahmoudFayed/atom-language-ring' into submodule path '/home/runner/work/linguist/linguist/vendor/grammars/language-ring' failed
Failed to clone 'vendor/grammars/language-ring'. Retry scheduled
Cloning into '/home/runner/work/linguist/linguist/vendor/grammars/language-ring'...
fatal: could not read Username for 'https://github.com/': No such device or address
fatal: clone of 'https://github.com/MahmoudFayed/atom-language-ring' into submodule path '/home/runner/work/linguist/linguist/vendor/grammars/language-ring' failed
Failed to clone 'vendor/grammars/language-ring' a second time, aborting

@lildude

lildude commented Jul 28, 2025

Copy link
Copy Markdown
Member

Whooops. @MahmoudFayed it looks like you've removed a repo you added to Linguist back in #3662

Can you please restore it. You should find you can restore it by going to https://github.com/settings/deleted_repositories

@MahmoudFayed

Copy link
Copy Markdown
Contributor

@lildude I restored a copy for now by creating a fork in my account, but could you please use this link: https://github.com/ringpackages/atom-language-ring in the future.

@lildude

lildude commented Jul 28, 2025

Copy link
Copy Markdown
Member

@lildude I restored a copy for now by creating a fork in my account, but could you please use this link: https://github.com/ringpackages/atom-language-ring in the future.

Thanks @MahmoudFayed Can you please submit a PR to change the location. Details are in the CONTRIBUTING.md file.

@MahmoudFayed

Copy link
Copy Markdown
Contributor

@lildude Thank you very much, I will submit a pull request.

@Alhadis

Alhadis commented Jul 28, 2025

Copy link
Copy Markdown
Collaborator

@MahmoudFayed You can use script/add-grammar to simplify the process:

$ ./script/add-grammar --replace atom-language-ring https://github.com/ringpackages/atom-language-ring

Replacing a grammar submodule by hand is cumberstome, finicky, and involves several annoying steps. Hence why script/add-grammar should be used instead.

@MahmoudFayed

Copy link
Copy Markdown
Contributor

@Alhadis Thank you very much, I will use the script.

@dubadub

dubadub commented Aug 1, 2025

Copy link
Copy Markdown
Contributor Author

@MahmoudFayed I'm wondering if you managed to replace?

@MahmoudFayed

Copy link
Copy Markdown
Contributor

@MahmoudFayed I'm wondering if you managed to replace?

@dubadub I decided to keep the current package rather than switch to a different one. I updated its description to note that it's used by github.com/github-linguist, so I can easily remember this.

@rudywasfound

Copy link
Copy Markdown
Contributor

you cooked with this one!!!

@dubadub

dubadub commented Aug 13, 2025

Copy link
Copy Markdown
Contributor Author

@lildude I fixed tests, could you please approve running them when you get a chance?

@lildude

lildude commented Aug 13, 2025

Copy link
Copy Markdown
Member

Whoops @hernad, we're still using the https://github.com/hernad/atom-language-harbour grammar. Can you please restore it (feel free to archive it) or submit a PR to change to another grammar source.

@hernad

hernad commented Aug 13, 2025

Copy link
Copy Markdown

Sorry, I really haven't clue that someone depends on this repository.

I have looked at restore option, but there is information:

"These repositories were deleted, but can't be restored by you. Contact support if you want to restore them."

so I submitted support ticket https://support.github.com/ticket/personal/0/3665991

@MahmoudFayed

Copy link
Copy Markdown
Contributor

@lildude @hernad You could fork this repository: https://github.com/ausuwardi/atom-language-harbour in your account.

@hernad

hernad commented Aug 13, 2025

Copy link
Copy Markdown

I have done this.

@lildude

lildude commented Aug 13, 2025

Copy link
Copy Markdown
Member

Thanks @hernad

@dubadub

dubadub commented Aug 13, 2025

Copy link
Copy Markdown
Contributor Author

@lildude lildude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Aug 26, 2025
Merged via the queue into github-linguist:main with commit 2744e79 Aug 26, 2025
5 checks passed
JesusValeraDev pushed a commit to phel-lang/linguist that referenced this pull request Apr 18, 2026
* feat: add Cooklang

* feat: enable wrap

* fix: add via ./script/add-grammar

* fix: cleanup sublime

* fix: remove menu

* refactor: use source.cooklang instead of source.cook

* fix: tests

* Update license ref for Cooklang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants