Make use of additional editor modes by Alhadis · Pull Request #7494 · github-linguist/linguist · GitHub
Skip to content

Make use of additional editor modes#7494

Merged
Alhadis merged 2 commits into
mainfrom
missing-modes
Jul 18, 2025
Merged

Make use of additional editor modes#7494
Alhadis merged 2 commits into
mainfrom
missing-modes

Conversation

@Alhadis

@Alhadis Alhadis commented Jul 18, 2025

Copy link
Copy Markdown
Collaborator

Description

This pull-request adds missing CodeMirror and ACE editor modes to languages that aren't using them.

There were two additions I had to leave out:

  1. Unix Assembly's CodeMirror mode
    This is an upstream issue that I'll probably submit a patch for. If all goes well, expect a follow-up to this PR with the following changes:
    UPDATE: Already fixed in codemirror/codemirror5@98e86d1a. However, I'll hold off on adding text/x-gas for the same reasons as those discussed in item 2 (release cycles and what-have-you).

    diff --git a/lib/linguist/languages.yml b/lib/linguist/languages.yml
    index 70c9fd3a..10edf36f 100644
    --- a/lib/linguist/languages.yml
    +++ b/lib/linguist/languages.yml
    @@ -7844,6 +7844,8 @@ Unix Assembly:
       - unix asm
       tm_scope: source.x86
       ace_mode: assembly_x86
    +  codemirror_mode: gas
    +  codemirror_mime_type: text/x-gas
       language_id: 120
     Uno:
       type: programming
  2. Clue's ACE mode
    I've only omitted this because support for Clue was added very recently to the Ace project itself, and the odds are that Linguist will need to update whatever Ace editor version it uses before I can include the following addition too:

    diff --git a/lib/linguist/languages.yml b/lib/linguist/languages.yml
    index 66c4324c..39f044f6 100644
    --- a/lib/linguist/languages.yml
    +++ b/lib/linguist/languages.yml
    @@ -1241,7 +1241,7 @@ Clue:
       extensions:
       - ".clue"
       tm_scope: source.clue
    -  ace_mode: text
    +  ace_mode: clue
       language_id: 163763508
     CoNLL-U:
       type: data

(Checklist removed as it doesn't apply)

@Alhadis Alhadis requested a review from a team as a code owner July 18, 2025 00:52
@Alhadis Alhadis changed the title Missing modes Make use of additional editor modes Jul 18, 2025
@Alhadis Alhadis requested a review from lildude July 18, 2025 00:53
@Alhadis Alhadis added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit 1b43482 Jul 18, 2025
9 checks passed
@Alhadis Alhadis deleted the missing-modes branch July 18, 2025 09:30
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Oct 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants