{{ message }}
Build & push docker on release#7311
Merged
lildude merged 6 commits intoSep 20, 2025
Merged
Conversation
Signed-off-by: AlexNg <contact@ngjx.org>
Signed-off-by: AlexNg <contact@ngjx.org>
lildude
requested changes
Apr 6, 2025
lildude
left a comment
lildude
left a comment
Member
There was a problem hiding this comment.
Thanks for this. I've been meaning to come back to it as the original reservations about doing this automatically no longer apply.
lildude
changed the title
Co-Authored-by: Colin Seymour <colin@github.com> Signed-off-by: AlexNg <contact@ngjx.org>
Co-Authored-by: Colin Seymour <colin@github.com> Signed-off-by: AlexNg <contact@ngjx.org>
Co-Authored-by: Colin Seymour <colin@github.com> Signed-off-by: AlexNg <contact@ngjx.org>
Signed-off-by: AlexNg <contact@ngjx.org>
caffeine-addictt
force-pushed
the
feature/push-docker-automatically
branch
from
1acbba1 to
a14b285
Compare
lildude
approved these changes
Apr 20, 2025
lildude
left a comment
lildude
left a comment
Member
There was a problem hiding this comment.
I'm not going to merge this until we're about to make our next release as we won't have a docker image until then so we don't want the README referring to something that doesn't exist.
Member
Contributor
|
@lildude what about now 😁 |
Member
|
Whoops. I forgot again. Lets give it a go now. |
Member
JesusValeraDev
pushed a commit
to phel-lang/linguist
that referenced
this pull request
Apr 18, 2026
* ci(docker-release): Build & push docker on release Signed-off-by: AlexNg <contact@ngjx.org> * docs: Include docker command for ghcr.io image Signed-off-by: AlexNg <contact@ngjx.org> * refactor: Update workflow name Co-Authored-by: Colin Seymour <colin@github.com> Signed-off-by: AlexNg <contact@ngjx.org> * ci: Trigger on release instead of tag push Co-Authored-by: Colin Seymour <colin@github.com> Signed-off-by: AlexNg <contact@ngjx.org> * ci: Use docker/metadata-action Co-Authored-by: Colin Seymour <colin@github.com> Signed-off-by: AlexNg <contact@ngjx.org> * ci: Do not setup QEMU Signed-off-by: AlexNg <contact@ngjx.org> --------- Signed-off-by: AlexNg <contact@ngjx.org> Co-authored-by: Colin Seymour <colin@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I noticed that the instructions for running github-linguist as a docker image requires the end-user to build it locally. Thus for the sake of convenience, I made CI that runs against new tags and pushes to GitHub's
ghcr.iodocker repository. I have tested these changes on this fork of mine.Tags:
buildcache- for build caching (on the max setting)latestorprerelease- based on the release tag (should be fine as long as we stick to semver)commit SHAI've also updated README to include pulling images down from
ghcr.io.Cheers,
-Alex Ng J. X.
Closes #4613