Add fixtures_path to all_fixtures by DecimalTurn · Pull Request #7241 · github-linguist/linguist · GitHub
Skip to content

Add fixtures_path to all_fixtures#7241

Merged
lildude merged 2 commits into
github-linguist:mainfrom
DecimalTurn:test_fixtures
Feb 23, 2025
Merged

Add fixtures_path to all_fixtures#7241
lildude merged 2 commits into
github-linguist:mainfrom
DecimalTurn:test_fixtures

Conversation

@DecimalTurn

Copy link
Copy Markdown
Contributor

Description

By including files in #{fixtures_path}/#{language_name}, we ensure that files such as the ones in /test/fixtures/ActionScript/ are being used for tests which is not the case at the moment.

@DecimalTurn DecimalTurn requested a review from a team as a code owner February 17, 2025 12:45
@DecimalTurn

Copy link
Copy Markdown
Contributor Author

@lildude lildude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Feb 23, 2025
Merged via the queue into github-linguist:main with commit c959cb5 Feb 23, 2025
@DecimalTurn DecimalTurn deleted the test_fixtures branch February 23, 2025 15:30
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants