Update references to go-enry in documentation by lildude · Pull Request #7198 · github-linguist/linguist · GitHub
Skip to content

Update references to go-enry in documentation#7198

Merged
lildude merged 1 commit into
mainfrom
lildude/update-docs-no-go-enry
Jan 10, 2025
Merged

Update references to go-enry in documentation#7198
lildude merged 1 commit into
mainfrom
lildude/update-docs-no-go-enry

Conversation

@lildude

@lildude lildude commented Jan 10, 2025

Copy link
Copy Markdown
Member

Description

GitHub's search no longer users go-enry and instead uses an internally developed library for language detection. This still feeds off Linguist so the same delays and limitations apply.

This PR updates the docs to reflect we no longer use go-enry.

Checklist:

N/A

@lildude lildude requested a review from a team as a code owner January 10, 2025 09:54
@lildude lildude merged commit 09880c7 into main Jan 10, 2025
@lildude lildude deleted the lildude/update-docs-no-go-enry branch January 10, 2025 10:01
@DecimalTurn

Copy link
Copy Markdown
Contributor

@lildude

lildude commented Jan 13, 2025

Copy link
Copy Markdown
Member Author

It written in Rust.

@DecimalTurn

DecimalTurn commented Feb 16, 2025

Copy link
Copy Markdown
Contributor

Is it the project mentioned here?

I'm asking because I would like to confirm what engine is used for regex patterns. For instance, if they use this implementation of regex, they would have no support for possessive qualifiers (and most non-Re2 regex patterns) as discussed here. Which means we should probably try to avoid or remove them from the heuristics in Linguist.

@lildude

lildude commented Feb 17, 2025

Copy link
Copy Markdown
Member Author

Is it the project mentioned here?

Yup.

I'm asking because I would like to confirm what engine is used for regex patterns. For instance, if they use this implementation of regex, they would have no support for possessive qualifiers (and most non-Re2 regex patterns) as discussed here. Which means we should probably try to avoid or remove them from the heuristics in Linguist.

That's the implementation that is used and you raise a good point. Thanks and thanks for #7238.

If you've got an urge to fix more regexes, we have several regexes that need fixing as they don't run linearly or are vulnerable to ReDoS. I've started main...lildude/linear-regex-redos to add a test and clean them up as and when I have the time, so feel free to continue cleaning up our regexes.

@DecimalTurn

Copy link
Copy Markdown
Contributor

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants