Register `bun.lock` as JSON by RiskyMH · Pull Request #7193 · github-linguist/linguist · GitHub
Skip to content

Register bun.lock as JSON #7193

Merged
lildude merged 5 commits into
github-linguist:mainfrom
The-Fiery-Fire:bun
Mar 11, 2025
Merged

Register bun.lock as JSON #7193
lildude merged 5 commits into
github-linguist:mainfrom
The-Fiery-Fire:bun

Conversation

@RiskyMH

@RiskyMH RiskyMH commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

Description

Bun recently added a text lockfile called bun.lock (https://bun.sh/blog/bun-lock-text-lockfile) and it will soon become default.

Checklist:


Although bun.lock officially uses JSONC, this PR sets it to standard JSON. Bun only relies on the trailing comma feature, which JSON happens to support without errors. The main reason to use standard JSON is that it provides better syntax highlighting on GitHub (#6197)

@RiskyMH RiskyMH requested a review from a team as a code owner January 7, 2025 11:07
@RiskyMH

This comment was marked as outdated.

@Jarred-Sumner

Copy link
Copy Markdown

@DecimalTurn

Copy link
Copy Markdown
Contributor

The main reason to use standard JSON is that it provides better syntax highlighting on GitHub (#6197)

JSONC's syntax highlighting should be much better once #7255 is live on GitHub.

@lildude lildude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Mar 11, 2025
Merged via the queue into github-linguist:main with commit 2c93759 Mar 11, 2025
@okineadev

Copy link
Copy Markdown

@RiskyMH RiskyMH deleted the bun branch March 11, 2025 11:47
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants